Skip to content

Add synchronous replication docs#4947

Closed
CharLotteiu wants to merge 5 commits into
pingcap:masterfrom
CharLotteiu:sychronous-replication-conifg
Closed

Add synchronous replication docs#4947
CharLotteiu wants to merge 5 commits into
pingcap:masterfrom
CharLotteiu:sychronous-replication-conifg

Conversation

@CharLotteiu
Copy link
Copy Markdown
Contributor

@CharLotteiu CharLotteiu commented Nov 23, 2020

What is changed, added or deleted? (Required)

Add a document for the synchronous replication. Content migrated from tikv/tikv#7740 and tikv/website#211.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@CharLotteiu CharLotteiu added status/PTAL This PR is ready for reviewing. translation/from-docs This PR is translated from a PR in pingcap/docs. v5.0 This PR/issue applies to TiDB v5.0 labels Nov 23, 2020
@CharLotteiu CharLotteiu requested a review from TomShawn November 23, 2020 10:20
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Nov 25, 2020

@TomShawn, PTAL.

@TomShawn TomShawn requested a review from BusyJay November 26, 2020 02:44
TomShawn
TomShawn reviewed Nov 26, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments on wording
@BusyJay PTAL

Comment thread pd-configuration-file.md Outdated
Comment thread synchronous-replication.md Outdated
Comment thread synchronous-replication.md
Comment thread synchronous-replication.md Outdated
Comment thread synchronous-replication.md Outdated
Comment thread synchronous-replication.md Outdated
CharLotteiu
CharLotteiu commented Nov 26, 2020
View reviewed changes
Comment thread pd-control.md Outdated
@CharLotteiu @TomShawn
Apply suggestions from code review
b123037 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Nov 26, 2020

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 26, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Nov 28, 2020

@TomShawn, @BusyJay, PTAL.

1 similar comment
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Nov 30, 2020

@TomShawn, @BusyJay, PTAL.

@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Dec 1, 2020

After discussion with @BusyJay, we find that the feature name synchronous replication does not accurately describe this feature. @BusyJay is thinking of a new name and will update the English version first. So this PR is pending until the feature name is determined.

@TomShawn TomShawn added the status/WIP This PR is still working in progress. label Dec 1, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Dec 3, 2020

@TomShawn, @BusyJay, PTAL.

@yikeke yikeke added for-future-release This PR only applies to master for now and might cherry-pick to a future release. and removed v5.0 This PR/issue applies to TiDB v5.0 labels Mar 24, 2021
@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. and removed status/WIP This PR is still working in progress. labels Apr 12, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented May 7, 2021

After discussion with @BusyJay, we find that the feature name synchronous replication does not accurately describe this feature. @BusyJay is thinking of a new name and will update the English version first. So this PR is pending until the feature name is determined.

@BusyJay Any update?

@BusyJay
Copy link
Copy Markdown
Contributor

BusyJay commented May 7, 2021

The feature will be release in following sprints, when the docs can be updated.

@qiancai
Copy link
Copy Markdown
Collaborator

qiancai commented May 31, 2021

Hi @BusyJay, we are preparing the user docs for TiDB v5.1 and would like to know whether the doc changes of this PR apply to TiDB v5.1 or not. Would you please check and reply? Thanks!

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 23, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 23, 2021

@CharLotteiu: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jul 16, 2021

@BusyJay Any update?

@TomShawn TomShawn removed status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs This PR is translated from a PR in pingcap/docs. status/PTAL This PR is ready for reviewing. needs-cherry-pick-release-5.0 for-future-release This PR only applies to master for now and might cherry-pick to a future release. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Aug 13, 2021
@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. missing-translation-status This PR does not have translation status info. labels Aug 13, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Aug 13, 2021

This PR is superseded by #6843.

@TomShawn TomShawn closed this Aug 13, 2021
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 13, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Aug 13, 2021

@CharLotteiu: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BusyJay BusyJay Awaiting requested review from BusyJay

1 more reviewer

@TomShawn TomShawn TomShawn left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

missing-translation-status This PR does not have translation status info. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@CharLotteiu @ti-srebot @TomShawn @BusyJay @qiancai @ti-chi-bot @yikeke