Skip to content

add dr auto sync#6843

Merged
ti-chi-bot merged 7 commits into
pingcap:masterfrom
nolouch:two-dc
Aug 13, 2021
Merged

add dr auto sync#6843
ti-chi-bot merged 7 commits into
pingcap:masterfrom
nolouch:two-dc

Conversation

@nolouch
Copy link
Copy Markdown
Member

@nolouch nolouch commented Aug 11, 2021

Signed-off-by: nolouch nolouch@gmail.com

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Aug 11, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn August 11, 2021 06:40
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 11, 2021
@nolouch nolouch requested review from BusyJay and disksing August 11, 2021 06:40
@TomShawn TomShawn added translation/doing This PR’s assignee is translating this PR. v5.2 This PR/issue applies to TiDB v5.2. status/PTAL This PR is ready for reviewing. and removed missing-translation-status This PR does not have translation status info. labels Aug 11, 2021
@nolouch nolouch force-pushed the two-dc branch 3 times, most recently from decf79b to 22fd4a6 Compare August 11, 2021 07:22
disksing
disksing reviewed Aug 11, 2021
View reviewed changes
Comment thread two-data-centers-in-one-city-deployment.md Outdated
disksing
disksing reviewed Aug 11, 2021
View reviewed changes
Comment thread two-data-centers-in-one-city-deployment.md Outdated
Comment thread two-data-centers-in-one-city-deployment.md Outdated
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Aug 11, 2021

@disksing: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@nolouch
add dr auto sync
1fafa88 
Signed-off-by: nolouch <nolouch@gmail.com>
TomShawn
TomShawn reviewed Aug 12, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the first round of review

Comment thread two-data-centers-in-one-city-deployment.md Outdated
Comment thread two-data-centers-in-one-city-deployment.md Outdated
Comment thread two-data-centers-in-one-city-deployment.md Outdated
Comment thread two-data-centers-in-one-city-deployment.md Outdated
Comment thread two-data-centers-in-one-city-deployment.md Outdated
Comment thread two-data-centers-in-one-city-deployment.md Outdated
Comment thread two-data-centers-in-one-city-deployment.md Outdated
Comment thread two-data-centers-in-one-city-deployment.md Outdated
Comment thread two-data-centers-in-one-city-deployment.md Outdated
Comment thread two-data-centers-in-one-city-deployment.md Outdated
TomShawn and others added 6 commits August 13, 2021 11:38
@TomShawn
Update two-data-centers-in-one-city-deployment.md
5f691ae
@TomShawn
refine
1df6157
@TomShawn
add back spaces
8d58c86
@nolouch
update png
8d03348 
Signed-off-by: nolouch <nolouch@gmail.com>
@nolouch
try fix
a004752 
Signed-off-by: nolouch <nolouch@gmail.com>
@TomShawn
add toc
1862541
TomShawn
TomShawn approved these changes Aug 13, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 13, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Aug 13, 2021

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 13, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Aug 13, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Aug 13, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 1862541

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 13, 2021
@ti-chi-bot ti-chi-bot merged commit e27323e into pingcap:master Aug 13, 2021
@nolouch nolouch deleted the two-dc branch August 13, 2021 08:14
@TomShawn TomShawn mentioned this pull request Aug 13, 2021
Closed
9 tasks
@Liuxiaozhen12 Liuxiaozhen12 mentioned this pull request Aug 17, 2021
Merged
12 tasks
@Liuxiaozhen12 Liuxiaozhen12 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Aug 17, 2021
Liuxiaozhen12 pushed a commit to Liuxiaozhen12/docs-cn that referenced this pull request Aug 26, 2021
revert pingcap#6843
2ce1784
@Liuxiaozhen12 Liuxiaozhen12 mentioned this pull request Aug 26, 2021
Merged
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Aug 26, 2021
@ti-chi-bot
revert pingcap#6843
d0a8d77
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 26, 2021
Merged
@Liuxiaozhen12 Liuxiaozhen12 mentioned this pull request Oct 8, 2021
Merged
13 tasks
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 8, 2021
Merged
13 tasks
@HuSharp HuSharp mentioned this pull request Aug 22, 2023
Merged
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@disksing disksing disksing approved these changes

@BusyJay BusyJay Awaiting requested review from BusyJay

+1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Liuxiaozhen12 Liuxiaozhen12

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v5.2 This PR/issue applies to TiDB v5.2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nolouch @ti-chi-bot @TomShawn @disksing @Liuxiaozhen12