Skip to content

tidb config: add txn-entry-size-limit#5158

Merged
TomShawn merged 4 commits into
pingcap:masterfrom
youjiali1995:add-txn-entry-size-limit
Dec 29, 2020
Merged

tidb config: add txn-entry-size-limit#5158
TomShawn merged 4 commits into
pingcap:masterfrom
youjiali1995:add-txn-entry-size-limit

Conversation

@youjiali1995
Copy link
Copy Markdown
Contributor

@youjiali1995 youjiali1995 commented Dec 23, 2020

Signed-off-by: youjiali1995 zlwgx1023@gmail.com

What is changed, added or deleted? (Required)

Add a new configuration. It's introduced in v5.0 and v4.0.10. https://github.com/pingcap/tidb/pull/21843/files

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions) Follow UP: CP to release-4.0 after v4.0.10 is released
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>
@cfzjywxk
Copy link
Copy Markdown
Contributor

LGTM

@ti-srebot
Copy link
Copy Markdown
Contributor

@cfzjywxk, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: docs(slack).

@TomShawn TomShawn added needs-cherry-pick-4.0 translation/doing This PR’s assignee is translating this PR. labels Dec 24, 2020
@TomShawn TomShawn self-requested a review December 24, 2020 03:04
@TomShawn TomShawn added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 24, 2020
Comment thread tidb-configuration-file.md Outdated
Comment thread tidb-configuration-file.md Outdated
@TomShawn
Copy link
Copy Markdown
Contributor

@youjiali1995 Looks like pingcap/tidb#21843 will only be merged into release-4.0. Why should this PR be merged into master?

@youjiali1995
Copy link
Copy Markdown
Contributor Author

youjiali1995 commented Dec 24, 2020

@youjiali1995 Looks like pingcap/tidb#21843 will only be merged into release-4.0. Why should this PR be merged into master?

It has been merged into master. pingcap/tidb#18231

@TomShawn TomShawn added needs-cherry-pick-5.0 v5.0 This PR/issue applies to TiDB v5.0 labels Dec 29, 2020
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread tidb-configuration-file.md Outdated
@TomShawn TomShawn added requires-followup This PR requires a follow-up task after being merged. and removed needs-cherry-pick-4.0 labels Dec 29, 2020
@TomShawn
Copy link
Copy Markdown
Contributor

Follow-up: cherry-pick to v4.0 after v4.0.10 is released.

@TomShawn TomShawn merged commit 309bba5 into pingcap:master Dec 29, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Dec 29, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Copy Markdown
Contributor

cherry pick to release-5.0 in PR #5200

TomShawn pushed a commit that referenced this pull request Dec 29, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Lei Zhao <zlwgx1023@gmail.com>
@Joyinqin
Copy link
Copy Markdown
Contributor

/label translation/done

TomShawn added a commit that referenced this pull request Jan 15, 2021
* cherry pick #5158 to release-4.0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* Update tidb-configuration-file.md

Co-authored-by: Lei Zhao <zlwgx1023@gmail.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@youjiali1995 youjiali1995 mentioned this pull request May 10, 2021
10 tasks
@ti-chi-bot ti-chi-bot mentioned this pull request May 20, 2021
10 tasks
This was referenced Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v5.0 This PR/issue applies to TiDB v5.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants