Skip to content

update txn-entry-size-limit import version#6221

Closed
glkappe wants to merge 1 commit into
pingcap:masterfrom
glkappe:patch-69
Closed

update txn-entry-size-limit import version#6221
glkappe wants to merge 1 commit into
pingcap:masterfrom
glkappe:patch-69

Conversation

@glkappe
Copy link
Copy Markdown
Contributor

@glkappe glkappe commented May 8, 2021

update txn-entry-size-limit import version

https://docs.pingcap.com/zh/tidb/v4.0/tidb-configuration-file#txn-entry-size-limit-%E4%BB%8E-v4010-%E7%89%88%E6%9C%AC%E5%BC%80%E5%A7%8B%E5%BC%95%E5%85%A5

Please conduct a technical review and merge as soon as possible

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Copy Markdown
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot requested a review from TomShawn May 8, 2021 09:30
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 8, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented May 8, 2021

@glkappe See #5158. This config is introduced in v5.0.0-rc and v4.0.10. v5.0.0-rc is actually earlier than v4.0.10. So in master, "从 v5.0 版本开始引入" is correct.

@glkappe
Copy link
Copy Markdown
Contributor Author

glkappe commented May 10, 2021

@glkappe See #5158. This config is introduced in v5.0.0-rc and v4.0.10. v5.0.0-rc is actually earlier than v4.0.10. So in master, "从 v5.0 版本开始引入" is correct.

https://docs.pingcap.com/zh/tidb/v4.0/tidb-configuration-file#txn-entry-size-limit-%E4%BB%8E-v4010-%E7%89%88%E6%9C%AC%E5%BC%80%E5%A7%8B%E5%BC%95%E5%85%A5

So I should believe that v4 or v5 document information?

@TomShawn
Copy link
Copy Markdown
Contributor

@glkappe See #5158. This config is introduced in v5.0.0-rc and v4.0.10. v5.0.0-rc is actually earlier than v4.0.10. So in master, "从 v5.0 版本开始引入" is correct.

https://docs.pingcap.com/zh/tidb/v4.0/tidb-configuration-file#txn-entry-size-limit-%E4%BB%8E-v4010-%E7%89%88%E6%9C%AC%E5%BC%80%E5%A7%8B%E5%BC%95%E5%85%A5

So I should believe that v4 or v5 document information?

  • If you are using the v4.0 cluster, your reference doc should be the v4.0 doc, which says that this config is introduced in v4.0.10.
  • If you are using the v5.0 cluster, your reference doc should be the v5.0 doc, which says that this config is introduced in v5.0.

@glkappe
Copy link
Copy Markdown
Contributor Author

glkappe commented May 13, 2021

如果找个参数是 v5.0.1 引入的,这个更改可能就不合适了,后面再官方文档确认参数引入版本可能需要看多个版本的 doc 了,我将关闭这个 pr,非常感谢解决。

@glkappe glkappe closed this May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants