Skip to content

sql-statements: use EBNF to render syntax diagrams - second batch#5376

Merged
CharLotteiu merged 5 commits into
pingcap:masterfrom
CharLotteiu:ebnf-diagram-replace-patch-b
Jan 26, 2021
Merged

sql-statements: use EBNF to render syntax diagrams - second batch#5376
CharLotteiu merged 5 commits into
pingcap:masterfrom
CharLotteiu:ebnf-diagram-replace-patch-b

Conversation

@CharLotteiu
Copy link
Copy Markdown
Contributor

@CharLotteiu CharLotteiu commented Jan 22, 2021 •
edited
Loading

What is changed, added or deleted? (Required)

This PR changes the synopsis sections of BEGIN, CHANGE, COMMIT, CREATE, DEALLOCATE, DELETE, DO, and DROP statements to use the ```ebnf+diagrm block, replacing the original image-based sqlgrams. It is a follow-up PR to pingcap/docs#4389.

To avoid making one single PR too large, I will open 4-5 follow-up PRs to process sql-statements files in batches. And I will delete all image files in the last PR in case of any display issues.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@CharLotteiu CharLotteiu added needs-cherry-pick-3.1 status/PTAL This PR is ready for reviewing. translation/doing This PR’s assignee is translating this PR. requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. labels Jan 22, 2021
@CharLotteiu CharLotteiu mentioned this pull request Jan 22, 2021
Closed
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jan 24, 2021

@kennytm, @TomShawn, PTAL.

kennytm
kennytm reviewed Jan 24, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jan 24, 2021

@kennytm, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: docs(slack).

TomShawn
TomShawn approved these changes Jan 26, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 26, 2021
@CharLotteiu CharLotteiu merged commit 541d0a6 into pingcap:master Jan 26, 2021
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jan 26, 2021
@CharLotteiu @ti-srebot
cherry pick pingcap#5376 to release-2.1
efb6c20 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 26, 2021
Closed
10 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jan 26, 2021

cherry pick to release-2.1 in PR #5406

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jan 26, 2021
@CharLotteiu @ti-srebot
cherry pick pingcap#5376 to release-3.0
cc23995 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 26, 2021
Closed
10 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jan 26, 2021

cherry pick to release-3.0 in PR #5407

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jan 26, 2021
@CharLotteiu @ti-srebot
cherry pick pingcap#5376 to release-3.1
d9fdda3 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 26, 2021
Closed
10 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jan 26, 2021

cherry pick to release-3.1 in PR #5408

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jan 26, 2021
@CharLotteiu @ti-srebot
cherry pick pingcap#5376 to release-4.0
6055760 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 26, 2021
Merged
10 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jan 26, 2021

cherry pick to release-4.0 in PR #5409

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jan 26, 2021
@CharLotteiu @ti-srebot
cherry pick pingcap#5376 to release-5.0
7425fff 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 26, 2021
Merged
10 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jan 26, 2021

cherry pick to release-5.0 in PR #5410

CharLotteiu added a commit that referenced this pull request Jan 27, 2021
@ti-srebot @CharLotteiu
cherry pick #5376 to release-5.0 (#5410)
0e23d7c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Charlotte Liu <37295236+CharLotteiu@users.noreply.github.com>
CharLotteiu added a commit that referenced this pull request Jan 27, 2021
@ti-srebot @CharLotteiu
cherry pick #5376 to release-4.0 (#5409)
bc1899a 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Charlotte Liu <37295236+CharLotteiu@users.noreply.github.com>
@CharLotteiu CharLotteiu mentioned this pull request Apr 27, 2021
Merged
10 tasks
@CharLotteiu
Copy link
Copy Markdown
Contributor Author

CharLotteiu commented Apr 27, 2021

/remove-translation doing
/translation done

@ti-chi-bot ti-chi-bot added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Apr 27, 2021
This was referenced Apr 28, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kennytm kennytm kennytm left review comments

+1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@CharLotteiu CharLotteiu

Labels

requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@CharLotteiu @ti-srebot @kennytm @TomShawn @ti-chi-bot