Skip to content

sql-statements: use EBNF to render syntax diagrams - second batch#5531

Merged
ti-chi-bot merged 2 commits into
pingcap:masterfrom
CharLotteiu:ebnf-diagram-replace-patch-2
Apr 28, 2021
Merged

sql-statements: use EBNF to render syntax diagrams - second batch#5531
ti-chi-bot merged 2 commits into
pingcap:masterfrom
CharLotteiu:ebnf-diagram-replace-patch-2

Conversation

@CharLotteiu
Copy link
Copy Markdown
Contributor

@CharLotteiu CharLotteiu commented Apr 27, 2021 •
edited
Loading

What is changed, added or deleted? (Required)

This PR changes the synopsis sections of BEGIN, CHANGE, COMMIT, CREATE, DEALLOCATE, DELETE, DO, and DROP statements to use the ```ebnf+diagrm block, replacing the original image-based sqlgrams. It is a follow-up PR to #4389.

To avoid making one single PR too large, I will open 4-5 follow-up PRs to process sql-statements files in batches. And I will delete all image files in the last PR in case of any display issues.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot requested a review from TomShawn April 27, 2021 12:15
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 27, 2021
@CharLotteiu
Copy link
Copy Markdown
Contributor Author

CharLotteiu commented Apr 27, 2021

/label needs-cherry-pick-5.0
/label needs-cherry-pick-4.0
/translation from-docs-cn

@ti-chi-bot ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-5.0 and removed missing-translation-status This PR does not have translation status info. labels Apr 27, 2021
@CharLotteiu
Copy link
Copy Markdown
Contributor Author

CharLotteiu commented Apr 27, 2021

/label requires-version-specific-changes

@ti-chi-bot ti-chi-bot added the requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. label Apr 27, 2021
TomShawn
TomShawn approved these changes Apr 28, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

Comment thread sql-statements/sql-statement-create-binding.md
Comment thread sql-statements/sql-statement-create-binding.md
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Apr 28, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 28, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 28, 2021

/label require-LGT1

@ti-chi-bot ti-chi-bot added the require-LGT1 Indicates that the PR requires an LGTM. label Apr 28, 2021
@CharLotteiu @TomShawn
Apply suggestions from code review
17a4838 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 28, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Apr 28, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 17a4838

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 28, 2021
@ti-chi-bot ti-chi-bot merged commit f2dfc09 into pingcap:master Apr 28, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 28, 2021
@CharLotteiu @ti-srebot
cherry pick pingcap#5531 to release-4.0
62def13 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 28, 2021
Merged
10 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Apr 28, 2021

cherry pick to release-4.0 in PR #5536

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 28, 2021
@CharLotteiu @ti-srebot
cherry pick pingcap#5531 to release-5.0
18d90f2 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 28, 2021
Merged
10 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Apr 28, 2021

cherry pick to release-5.0 in PR #5537

ti-chi-bot pushed a commit that referenced this pull request Apr 28, 2021
@ti-srebot
sql-statements: use EBNF to render syntax diagrams - second batch (#5531
f536940 
) (#5537)
ti-chi-bot pushed a commit that referenced this pull request Apr 28, 2021
@ti-srebot
sql-statements: use EBNF to render syntax diagrams - second batch (#5531
b33fb06 
) (#5536)
@CharLotteiu CharLotteiu deleted the ebnf-diagram-replace-patch-2 branch July 9, 2021 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

require-LGT1 Indicates that the PR requires an LGTM. requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CharLotteiu @ti-chi-bot @TomShawn @ti-srebot