Skip to content

Update tidb-configuration-file.md#5783

Merged
ti-chi-bot merged 2 commits into
pingcap:masterfrom
HuGanghui:add-config
Jun 22, 2021
Merged

Update tidb-configuration-file.md#5783
ti-chi-bot merged 2 commits into
pingcap:masterfrom
HuGanghui:add-config

Conversation

@HuGanghui
Copy link
Copy Markdown
Contributor

@HuGanghui HuGanghui commented Mar 22, 2021 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Update tidb-configuration-file.md, add tcp-no-delay

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

ref pingcap/tidb#23440

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 22, 2021
@HuGanghui HuGanghui mentioned this pull request Mar 22, 2021
Merged
11 tasks
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Mar 23, 2021

/cc @xhebox
/translation done
/assign @HuGanghui

@ti-chi-bot ti-chi-bot added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Mar 23, 2021
@ti-chi-bot ti-chi-bot requested a review from xhebox March 23, 2021 03:25
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Mar 23, 2021
@xhebox
Copy link
Copy Markdown
Contributor

xhebox commented Mar 23, 2021

/lgtm

I am not a reviewer, though.

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Mar 23, 2021

@xhebox: /lgtm is only allowed for the reviewers in list.

Details

In response to this:

/lgtm

I am not a reviewer, though.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@xhebox
Copy link
Copy Markdown
Contributor

xhebox commented Mar 23, 2021

/cc @djshow832 @bb7133

@ti-chi-bot ti-chi-bot requested review from bb7133 and djshow832 March 23, 2021 03:33
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Mar 23, 2021

/status PTAL

@ti-chi-bot ti-chi-bot added the status/PTAL This PR is ready for reviewing. label Mar 23, 2021
TomShawn
TomShawn reviewed Mar 23, 2021
View reviewed changes
Comment thread tidb-configuration-file.md Outdated
@yikeke yikeke added the for-future-release This PR only applies to master for now and might cherry-pick to a future release. label Mar 24, 2021
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Mar 25, 2021

@TomShawn, @bb7133, @xhebox, @djshow832, PTAL.

@bb7133
Copy link
Copy Markdown
Member

bb7133 commented Mar 26, 2021

/pr

@bb7133
Copy link
Copy Markdown
Member

bb7133 commented Mar 26, 2021

/uncc

@ti-chi-bot ti-chi-bot removed the request for review from bb7133 March 26, 2021 09:47
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented May 31, 2021

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 31, 2021
@qiancai
Copy link
Copy Markdown
Collaborator

qiancai commented Jun 13, 2021

Hi @HuGanghui， would you please confirm if the doc changes in this PR are for TiDB v5.1? Thanks!

@qiancai qiancai added v5.1 This PR/issue applies to TiDB v5.1. and removed for-future-release This PR only applies to master for now and might cherry-pick to a future release. labels Jun 22, 2021
qiancai
qiancai reviewed Jun 22, 2021
View reviewed changes
Comment thread tidb-configuration-file.md Outdated
@qiancai qiancai added the area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. label Jun 22, 2021
@bb7133
Copy link
Copy Markdown
Member

bb7133 commented Jun 22, 2021

/lgtm

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 22, 2021

@bb7133: Please use GitHub review feature instead of /lgtm [cancel] when you want to submit review to the pull request.
For how to use GitHub review feature, see also this document provided by GitHub.

For the reason we drop support to the commands, see also this page.
This reply is being used as a temporary reply during the migration of review process and will be removed on July 1st.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 22, 2021
@TomShawn TomShawn added needs-cherry-pick-release-5.1 and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 22, 2021
TomShawn
TomShawn approved these changes Jun 22, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 22, 2021

@TomShawn: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jun 22, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 22, 2021

@TomShawn: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn TomShawn added the sig/docs Indicates that the Issue or PR belongs to the docs SIG. label Jun 22, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 22, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • bb7133

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 22, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jun 22, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 22, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: dd331b5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 22, 2021
@ti-chi-bot ti-chi-bot merged commit 0c86241 into pingcap:master Jun 22, 2021
This was referenced Jun 22, 2021
Merged
Merged
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 22, 2021

In response to a cherrypick label: new pull request created: #6493.

ti-chi-bot added a commit that referenced this pull request Jun 22, 2021
@ti-chi-bot
Update tidb-configuration-file.md (#5783) (#6493)
f7ce61a
3AceShowHand pushed a commit to 3AceShowHand/docs-cn that referenced this pull request Jul 27, 2021
@HuGanghui @3AceShowHand
Update tidb-configuration-file.md (pingcap#5783)
acb80f4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qiancai qiancai qiancai left review comments

@bb7133 bb7133 bb7133 approved these changes

@xhebox xhebox Awaiting requested review from xhebox

@djshow832 djshow832 Awaiting requested review from djshow832

+1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@HuGanghui HuGanghui

Labels

area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. sig/docs Indicates that the Issue or PR belongs to the docs SIG. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v5.1 This PR/issue applies to TiDB v5.1.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@HuGanghui @TomShawn @xhebox @ti-chi-bot @ti-srebot @bb7133 @qiancai @yikeke