Skip to content

Update tidb-configuration-file.md#5070

Merged
ti-chi-bot merged 2 commits into
pingcap:masterfrom
HuGanghui:add-config
Jun 22, 2021
Merged

Update tidb-configuration-file.md#5070
ti-chi-bot merged 2 commits into
pingcap:masterfrom
HuGanghui:add-config

Conversation

@HuGanghui
Copy link
Copy Markdown
Contributor

@HuGanghui HuGanghui commented Mar 22, 2021 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Update tidb-configuration-file.md, add tcp-no-delay

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

ref pingcap/tidb#23440

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-srebot ti-srebot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Mar 22, 2021
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 22, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added the missing-translation-status This PR does not have translation status info. label Mar 22, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Mar 22, 2021

Welcome @HuGanghui!

It looks like this is your first PR to pingcap/docs 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/docs. 😃

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 22, 2021
@xhebox
Copy link
Copy Markdown
Contributor

xhebox commented Mar 23, 2021

/cc @djshow832 @bb7133

@ti-chi-bot ti-chi-bot requested review from bb7133 and djshow832 March 23, 2021 03:33
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Mar 23, 2021

/status PTAL
/translation from-docs-cn

@ti-chi-bot ti-chi-bot added status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. and removed missing-translation-status This PR does not have translation status info. labels Mar 23, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Mar 23, 2021

@HuGanghui Is master the only affected version?

@xhebox
Copy link
Copy Markdown
Contributor

xhebox commented Mar 23, 2021 •
edited
Loading

@TomShawn Yes, there is no cherry-pick so far. And, to my best knowledge, there is no plan to cherry-pick, either.

@HuGanghui HuGanghui mentioned this pull request Mar 23, 2021
Merged
11 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Mar 25, 2021

@bb7133, @djshow832, PTAL.

@yikeke
Copy link
Copy Markdown
Contributor

yikeke commented Mar 25, 2021

/label for-future-release

@ti-chi-bot ti-chi-bot added the for-future-release This PR only applies to master for now and might cherry-pick to a future release. label Mar 25, 2021
@bb7133
Copy link
Copy Markdown
Member

bb7133 commented Apr 2, 2021

/uncc bb7133

@ti-chi-bot ti-chi-bot removed the request for review from bb7133 April 2, 2021 09:52
@bb7133
Copy link
Copy Markdown
Member

bb7133 commented Apr 2, 2021

I will try to review it, after I become a reviewer.

@qiancai
Copy link
Copy Markdown
Collaborator

qiancai commented May 31, 2021

Hi @HuGanghui and @djshow832, we are preparing the user docs for TiDB v5.1 and would like to know whether the doc changes of this PR apply to TiDB v5.1 or not. Would you please check and reply? Thanks!

@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented May 31, 2021

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 31, 2021
@TomShawn TomShawn added v5.1 This PR/issue applies to TiDB v5.1. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. for-future-release This PR only applies to master for now and might cherry-pick to a future release. labels Jun 22, 2021
TomShawn
TomShawn reviewed Jun 22, 2021
View reviewed changes
Comment thread tidb-configuration-file.md Outdated
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 22, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qiancai

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 22, 2021
@TomShawn TomShawn added needs-cherry-pick-release-5.1 require-LGT1 Indicates that the PR requires an LGTM. labels Jun 22, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jun 22, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 22, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 663ecd8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 22, 2021
@ti-chi-bot ti-chi-bot merged commit ce6030e into pingcap:master Jun 22, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 22, 2021
Merged
11 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 22, 2021

In response to a cherrypick label: new pull request created: #5821.

ti-chi-bot added a commit that referenced this pull request Jun 22, 2021
@ti-chi-bot
Update tidb-configuration-file.md (#5070) (#5821)
ed00c06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qiancai qiancai qiancai approved these changes

@djshow832 djshow832 Awaiting requested review from djshow832

+1 more reviewer

@TomShawn TomShawn TomShawn left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v5.1 This PR/issue applies to TiDB v5.1.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@HuGanghui @CLAassistant @ti-chi-bot @xhebox @TomShawn @ti-srebot @yikeke @bb7133 @qiancai