Skip to content

br:tidy up the incompatible issues in using BR tools. (#5224)#5802

Closed
ti-srebot wants to merge 1 commit into
pingcap:release-4.0from
ti-srebot:release-4.0-d01e2d33c600
Closed

br:tidy up the incompatible issues in using BR tools. (#5224)#5802
ti-srebot wants to merge 1 commit into
pingcap:release-4.0from
ti-srebot:release-4.0-d01e2d33c600

Conversation

@ti-srebot
Copy link
Copy Markdown
Contributor

@ti-srebot ti-srebot commented Mar 23, 2021

cherry-pick #5224 to release-4.0
You can switch your code base to this Pull Request by using git-extras:

# In docs-cn repo:
git pr https://github.com/pingcap/docs-cn/pull/5802

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/docs-cn.git pr/5802:release-4.0-d01e2d33c600

First-time contributors' checklist

What is changed, added or deleted? (Required)

Tidy up the incompatible issues in using BR tools.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Copy Markdown
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-srebot ti-srebot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. labels Mar 23, 2021
@ti-srebot ti-srebot requested review from TomShawn and overvenus March 23, 2021 10:02
@ti-srebot
Copy link
Copy Markdown
Contributor Author

@3pointer please accept the invitation then you can push to the cherry-pick pull requests.
https://github.com/ti-srebot/docs-cn/invitations

@TomShawn TomShawn mentioned this pull request Mar 25, 2021
11 tasks
@TomShawn
Copy link
Copy Markdown
Contributor

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 30, 2021
@TomShawn TomShawn mentioned this pull request Apr 9, 2021
7 tasks
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 9, 2021

According to @3pointer's discretion, the content should be cherry-picked to release-4.0 in #5968. So I close this PR for now.

@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 9, 2021

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 9, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 9, 2021

/close

@ti-chi-bot ti-chi-bot closed this Apr 9, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

@TomShawn: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants