Skip to content

br: update minimum requirements#5842

Merged
ti-chi-bot merged 1 commit into
pingcap:masterfrom
overvenus:patch-6
Mar 25, 2021
Merged

br: update minimum requirements#5842
ti-chi-bot merged 1 commit into
pingcap:masterfrom
overvenus:patch-6

Conversation

@overvenus
Copy link
Copy Markdown
Member

@overvenus overvenus commented Mar 25, 2021

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from: N/A
  • Other reference link(s): N/A

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 25, 2021
@overvenus
Copy link
Copy Markdown
Member Author

overvenus commented Mar 25, 2021

/cc @TomShawn @3pointer

@ti-chi-bot ti-chi-bot requested review from 3pointer and TomShawn March 25, 2021 09:04
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Mar 25, 2021

/label needs-cherry-pick-4.0
/label needs-cherry-pick-5.0
/status PTAL
/assign
/translation doing
/label require-LGT1

@ti-chi-bot ti-chi-bot added status/PTAL This PR is ready for reviewing. translation/doing This PR’s assignee is translating this PR. needs-cherry-pick-4.0 require-LGT1 Indicates that the PR requires an LGTM. and removed missing-translation-status This PR does not have translation status info. labels Mar 25, 2021
3pointer
3pointer reviewed Mar 25, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@3pointer 3pointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Mar 25, 2021

/lgtm

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Mar 25, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. and removed needs-cherry-pick-4.0 labels Mar 25, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Mar 25, 2021

The v4.0 version can be modified in #5802.

@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Mar 25, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Mar 25, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 6b1692f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 25, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Mar 25, 2021

@TomShawn: These labels are not set on the issue: needs-cherry-pick-4.0.

Details

In response to this:

/remove-label needs-cherry-pick-4.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 355812f into pingcap:master Mar 25, 2021
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Mar 25, 2021
@overvenus @ti-srebot
cherry pick pingcap#5842 to release-5.0
00c4dcb 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 25, 2021
Merged
11 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Mar 25, 2021

cherry pick to release-5.0 in PR #5852

ti-chi-bot pushed a commit that referenced this pull request Mar 25, 2021
@ti-srebot
br: update minimum requirements (#5842) (#5852)
ae7480e
@TomShawn TomShawn mentioned this pull request Apr 12, 2021
Merged
10 tasks
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 12, 2021

/remove-translation doing
/translation done

@ti-chi-bot ti-chi-bot added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Apr 12, 2021
This was referenced Apr 19, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@3pointer 3pointer 3pointer left review comments

@TomShawn TomShawn Awaiting requested review from TomShawn

Assignees

@TomShawn TomShawn

Labels

require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@overvenus @TomShawn @ti-chi-bot @ti-srebot @3pointer