lightning: update lightning example binary version and download link by glorv · Pull Request #5897 · pingcap/docs-cn

glorv · 2021-03-31T06:37:45Z

First-time contributors' checklist

I've signed Contributor License Agreement that's required for repo owners to accept my contribution.

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

This PR is translated from:
Other reference link(s):

Do your changes match any of the following descriptions?

Might cause conflicts after applied to another branch
- The TiDB download page link is different between v3.0 and v5.0

glorv · 2021-03-31T06:38:01Z

@qiancai @kennytm @3pointer PTAL

qiancai · 2021-03-31T06:42:20Z

/cc @qiancai

qiancai · 2021-03-31T06:42:47Z

/cc @kennytm @3pointer

kennytm · 2021-03-31T06:49:24Z

/lgtm

ti-chi-bot · 2021-03-31T06:49:27Z

@kennytm: /lgtm is only allowed for the reviewers in list.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

qiancai · 2021-03-31T06:59:36Z

 ### 第 1 步：部署 TiDB 集群

-在开始数据导入之前，需先部署一套要进行导入的 TiDB 集群（版本要求 2.0.9 以上），本教程使用 TiDB 4.0.3 版本。部署方法可参考 [TiDB 部署方式](https://docs.pingcap.com/zh/tidb/v3.0/overview#部署方式)。
+在开始数据导入之前，需先部署一套要进行导入的 TiDB 集群（版本要求 2.0.9 以上），本教程使用 TiDB v5.0.0 版本。部署方法可参考 [使用 TiUP 部署 TiDB 集群](/production-deployment-using-tiup.md)。


因为此文档是针对 v5.0 的，所以这里的“（版本要求 2.0.9 以上）”可以删除。

Suggested change

在开始数据导入之前，需先部署一套要进行导入的 TiDB 集群（版本要求 2.0.9 以上），本教程使用 TiDB v5.0.0 版本。部署方法可参考 [使用 TiUP 部署 TiDB 集群](/production-deployment-using-tiup.md)。

在开始数据导入之前，需先部署一套要进行导入的 TiDB 集群，本教程使用 TiDB v5.0.0 版本为例。部署方法可参考 [使用 TiUP 部署 TiDB 集群](/production-deployment-using-tiup.md)。

那 master 文档需要保留么？🤔

master 代表正在开发的分支，就是 stable 以上的分支，所以也不需要保留。更多关于删除历史版本信息描述的讨论，可以参考 pingcap/docs#4549 哈。

qiancai · 2021-03-31T07:04:12Z

/assign @qiancai

qiancai · 2021-03-31T07:46:09Z

/label v5.0
/status require-change
/label needs-cherry-pick-5.0

TomShawn · 2021-04-01T03:14:27Z

/remove-status require-change
/status PTAL

ti-chi-bot · 2021-04-01T05:20:15Z

@qiancai: /lgtm is only allowed for the reviewers in list.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

qiancai · 2021-04-01T05:24:30Z

/translation doing

qiancai · 2021-04-01T05:26:34Z

 ### 第 2 步：下载 TiDB Lightning 安装包

-通过以下链接获取 TiDB Lightning 安装包（选择与 TiDB 集群相同的版本）：
+通过以下链接获取 TiDB Lightning 安装包（TiDB Lightning 完全兼容较低版本的 TiDB 集群， 建议选择最新稳定版本）：


Suggested change

通过以下链接获取 TiDB Lightning 安装包（TiDB Lightning 完全兼容较低版本的 TiDB 集群，建议选择最新稳定版本）：

通过以下链接获取 TiDB Lightning 安装包（TiDB Lightning 完全兼容较低版本的 TiDB 集群，建议选择最新稳定版本）：

qiancai · 2021-04-01T05:26:58Z

 #### 第 2 步：下载 TiDB Lightning 安装包

-在[工具下载](/download-ecosystem-tools.md#tidb-lightning)页面下载 TiDB Lightning 安装包（需选择与 TiDB 集群相同的版本）。
+在[工具下载](/download-ecosystem-tools.md#tidb-lightning)页面下载 TiDB Lightning 安装包（TiDB Lightning 完全兼容较低版本的 TiDB 集群， 建议选择最新稳定版本）。


Suggested change

在[工具下载](/download-ecosystem-tools.md#tidb-lightning)页面下载 TiDB Lightning 安装包（TiDB Lightning 完全兼容较低版本的 TiDB 集群，建议选择最新稳定版本）。

在[工具下载](/download-ecosystem-tools.md#tidb-lightning)页面下载 TiDB Lightning 安装包（TiDB Lightning 完全兼容较低版本的 TiDB 集群，建议选择最新稳定版本）。

qiancai · 2021-04-01T05:29:21Z

 ### 第 1 步：部署 TiDB 集群

-在开始数据导入之前，需先部署一套要进行导入的 TiDB 集群（版本要求 2.0.9 以上），本教程使用 TiDB 4.0.3 版本。部署方法可参考 [TiDB 部署方式](https://docs.pingcap.com/zh/tidb/v3.0/overview#部署方式)。
+在开始数据导入之前，需先部署一套要进行导入的 TiDB 集群。本教程以 TiDB v5.0.0 版本为例，具体部署方法可参考 [使用 TiUP 部署 TiDB 集群](/production-deployment-using-tiup.md)。


Suggested change

在开始数据导入之前，需先部署一套要进行导入的 TiDB 集群。本教程以 TiDB v5.0.0 版本为例，具体部署方法可参考 [使用 TiUP 部署 TiDB 集群](/production-deployment-using-tiup.md)。

在开始数据导入之前，需先部署一套要进行导入的 TiDB 集群。本教程以 TiDB v5.0.0 版本为例，具体部署方法可参考[使用 TiUP 部署 TiDB 集群](/production-deployment-using-tiup.md)。

ti-chi-bot · 2021-04-07T12:26:44Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

yikeke

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

qiancai · 2021-04-08T01:51:31Z

/remove-translation doing
/translation done

TomShawn · 2021-04-08T02:07:35Z

/merge

ti-chi-bot · 2021-04-08T02:07:38Z

@TomShawn: /merge in this pull request requires 2 /lgtm.

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

TomShawn · 2021-04-08T02:07:48Z

/label require-LGT1

TomShawn · 2021-04-08T02:09:07Z

/hold

…o update-lightning

TomShawn · 2021-04-08T02:29:04Z

/unhold

TomShawn · 2021-04-08T02:29:09Z

/merge

ti-chi-bot · 2021-04-08T02:29:13Z

This pull request has been accepted and is ready to merge.

Details

Commit hash: 5913f84

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot · 2021-04-08T02:31:06Z

cherry pick to release-5.0 in PR #5994

…5897) (#5994)

update lightning example binary version and download link

105c044

ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 31, 2021

ti-chi-bot requested a review from qiancai March 31, 2021 06:42

ti-chi-bot requested review from 3pointer and kennytm March 31, 2021 06:42

qiancai reviewed Mar 31, 2021

View reviewed changes

ti-chi-bot assigned qiancai Mar 31, 2021

ti-chi-bot added status/require-change Needs the author to address comments. v5.0 This PR/issue applies to TiDB v5.0 needs-cherry-pick-5.0 labels Mar 31, 2021

resolve comments

635796e

glorv force-pushed the update-lightning branch from 8ccd59e to 635796e Compare March 31, 2021 12:00

ti-chi-bot added status/PTAL This PR is ready for reviewing. and removed status/require-change Needs the author to address comments. labels Apr 1, 2021

ti-chi-bot added translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Apr 1, 2021

qiancai reviewed Apr 1, 2021

View reviewed changes

Update get-started-with-tidb-lightning.md

512d793

yikeke approved these changes Apr 7, 2021

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 7, 2021

qiancai mentioned this pull request Apr 8, 2021

lightning: update lightning example binary version and download link #5897 pingcap/docs#5262

Merged

11 tasks

ti-chi-bot added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Apr 8, 2021

ti-chi-bot added the require-LGT1 Indicates that the PR requires an LGTM. label Apr 8, 2021

ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 8, 2021

glorv added 2 commits April 8, 2021 10:21

remove old version desc

b4a07e9

Merge branch 'update-lightning' of ssh://github.com/glorv/docs-cn int…

5913f84

…o update-lightning

ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 8, 2021

ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 8, 2021

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 8, 2021

ti-chi-bot merged commit 569cc50 into pingcap:master Apr 8, 2021

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Apr 8, 2021

cherry pick pingcap#5897 to release-5.0

7ca70b9

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot mentioned this pull request Apr 8, 2021

lightning: update lightning example binary version and download link (#5897) #5994

Merged

8 tasks

ti-chi-bot pushed a commit that referenced this pull request Apr 8, 2021

lightning: update lightning example binary version and download link (#…

4d696a3

…5897) (#5994)

ti-srebot mentioned this pull request Apr 8, 2021

lightning: update lightning example binary version and download link #5897 (#5262) pingcap/docs#5263

Merged

11 tasks

glorv deleted the update-lightning branch June 21, 2024 07:14

	在开始数据导入之前，需先部署一套要进行导入的 TiDB 集群（版本要求 2.0.9 以上），本教程使用 TiDB v5.0.0 版本。部署方法可参考 [使用 TiUP 部署 TiDB 集群](/production-deployment-using-tiup.md)。
	在开始数据导入之前，需先部署一套要进行导入的 TiDB 集群，本教程使用 TiDB v5.0.0 版本为例。部署方法可参考 [使用 TiUP 部署 TiDB 集群](/production-deployment-using-tiup.md)。

	通过以下链接获取 TiDB Lightning 安装包（TiDB Lightning 完全兼容较低版本的 TiDB 集群，建议选择最新稳定版本）：
	通过以下链接获取 TiDB Lightning 安装包（TiDB Lightning 完全兼容较低版本的 TiDB 集群，建议选择最新稳定版本）：

	在[工具下载](/download-ecosystem-tools.md#tidb-lightning)页面下载 TiDB Lightning 安装包（TiDB Lightning 完全兼容较低版本的 TiDB 集群，建议选择最新稳定版本）。
	在[工具下载](/download-ecosystem-tools.md#tidb-lightning)页面下载 TiDB Lightning 安装包（TiDB Lightning 完全兼容较低版本的 TiDB 集群，建议选择最新稳定版本）。

	在开始数据导入之前，需先部署一套要进行导入的 TiDB 集群。本教程以 TiDB v5.0.0 版本为例，具体部署方法可参考 [使用 TiUP 部署 TiDB 集群](/production-deployment-using-tiup.md)。
	在开始数据导入之前，需先部署一套要进行导入的 TiDB 集群。本教程以 TiDB v5.0.0 版本为例，具体部署方法可参考[使用 TiUP 部署 TiDB 集群](/production-deployment-using-tiup.md)。

Conversation

glorv commented Mar 31, 2021

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

Uh oh!

glorv commented Mar 31, 2021

Uh oh!

qiancai commented Mar 31, 2021

Uh oh!

qiancai commented Mar 31, 2021

Uh oh!

kennytm commented Mar 31, 2021

Uh oh!

ti-chi-bot commented Mar 31, 2021

Uh oh!

qiancai Mar 31, 2021

Choose a reason for hiding this comment

Uh oh!

glorv Mar 31, 2021

Choose a reason for hiding this comment

Uh oh!

qiancai Apr 1, 2021

Choose a reason for hiding this comment

Uh oh!

qiancai commented Mar 31, 2021

Uh oh!

qiancai commented Mar 31, 2021

Uh oh!

TomShawn commented Apr 1, 2021

Uh oh!

ti-chi-bot commented Apr 1, 2021

Uh oh!

qiancai commented Apr 1, 2021

Uh oh!

qiancai Apr 1, 2021

Choose a reason for hiding this comment

Uh oh!

qiancai Apr 1, 2021

Choose a reason for hiding this comment

Uh oh!

qiancai Apr 1, 2021

Choose a reason for hiding this comment

Uh oh!

ti-chi-bot commented Apr 7, 2021

Uh oh!

qiancai commented Apr 8, 2021

Uh oh!

TomShawn commented Apr 8, 2021

Uh oh!

ti-chi-bot commented Apr 8, 2021

Uh oh!

TomShawn commented Apr 8, 2021

Uh oh!

TomShawn commented Apr 8, 2021

Uh oh!

TomShawn commented Apr 8, 2021

Uh oh!

TomShawn commented Apr 8, 2021

Uh oh!

ti-chi-bot commented Apr 8, 2021

Uh oh!

ti-srebot commented Apr 8, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants