Skip to content

lightning: update lightning example binary version and download link #5897#5262

Merged
ti-chi-bot merged 7 commits into
pingcap:masterfrom
qiancai:translate-lightning-update-lightning-example-binary-version-and-download-link-#5897
Apr 8, 2021
Merged

lightning: update lightning example binary version and download link #5897#5262
ti-chi-bot merged 7 commits into
pingcap:masterfrom
qiancai:translate-lightning-update-lightning-example-binary-version-and-download-link-#5897

Conversation

@qiancai
Copy link
Copy Markdown
Collaborator

@qiancai qiancai commented Apr 8, 2021

First-time contributors' checklist

What is changed, added or deleted? (Required)

Updated the version information from v4.0 to v5.0

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 8, 2021
@qiancai
Copy link
Copy Markdown
Collaborator Author

qiancai commented Apr 8, 2021

/label needs-cherry-pick-5.0
/label v5.0
/translation from-docs-cn

@ti-chi-bot ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-5.0 v5.0 This PR/issue applies to TiDB v5.0. and removed missing-translation-status This PR does not have translation status info. labels Apr 8, 2021
@qiancai
Copy link
Copy Markdown
Collaborator Author

qiancai commented Apr 8, 2021

/cc @glorv @TomShawn

@ti-chi-bot ti-chi-bot requested review from TomShawn and glorv April 8, 2021 01:53
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 8, 2021
@qiancai qiancai changed the title Updated the versions lightning: update lightning example binary version and download link #5897 Apr 8, 2021
@glorv
Copy link
Copy Markdown
Contributor

glorv commented Apr 8, 2021

LGTM

Comment thread get-started-with-tidb-lightning.md Outdated
Comment thread get-started-with-tidb-lightning.md Outdated
Comment thread tidb-lightning/deploy-tidb-lightning.md Outdated
Comment thread tidb-lightning/deploy-tidb-lightning.md Outdated
qiancai and others added 4 commits April 8, 2021 10:48
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 8, 2021

/lgtm
/label require-LGT1

@ti-chi-bot ti-chi-bot added the require-LGT1 Indicates that the PR requires an LGTM. label Apr 8, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 8, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 8, 2021

/lgtm

@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 8, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: d2f5be1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 8, 2021
@ti-chi-bot ti-chi-bot merged commit 8714f43 into pingcap:master Apr 8, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 8, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Copy Markdown
Contributor

cherry pick to release-5.0 in PR #5263

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

require-LGT1 Indicates that the PR requires an LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v5.0 This PR/issue applies to TiDB v5.0.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants