Skip to content

add MySQL compatibility in user-defined-variables.md#6062

Merged
ti-chi-bot merged 2 commits into
pingcap:masterfrom
Liuxiaozhen12:translate-the-note-in-user-defined-variables
Apr 25, 2021
Merged

add MySQL compatibility in user-defined-variables.md#6062
ti-chi-bot merged 2 commits into
pingcap:masterfrom
Liuxiaozhen12:translate-the-note-in-user-defined-variables

Conversation

@Liuxiaozhen12
Copy link
Copy Markdown
Contributor

@Liuxiaozhen12 Liuxiaozhen12 commented Apr 19, 2021

First-time contributors' checklist

What is changed, added or deleted? (Required)

add a note translation about MySQL compatibility.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 19, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. labels Apr 19, 2021
@ti-chi-bot ti-chi-bot requested a review from TomShawn April 19, 2021 10:01
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 19, 2021
@Joyinqin
Copy link
Copy Markdown
Contributor

Joyinqin commented Apr 19, 2021

/translation from-docs

@ti-chi-bot ti-chi-bot added translation/from-docs This PR is translated from a PR in pingcap/docs. and removed missing-translation-status This PR does not have translation status info. labels Apr 19, 2021
@Joyinqin
Copy link
Copy Markdown
Contributor

Joyinqin commented Apr 19, 2021

/label needs-cherry-pick-5.0

TomShawn
TomShawn reviewed Apr 19, 2021
View reviewed changes
Comment thread user-defined-variables.md Outdated
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 19, 2021

/cc @XuHuaiyu

@ti-chi-bot ti-chi-bot requested a review from XuHuaiyu April 19, 2021 10:54
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 19, 2021

/retitle add MySQL compatibility in user-defined-variables.md

@ti-chi-bot ti-chi-bot changed the title add a note translation add MySQL compatibility in user-defined-variables.md Apr 19, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 19, 2021 •
edited
Loading

@Liuxiaozhen12 A good PR title should be clear and concise enough to summarize what changes you have made.

@Liuxiaozhen12 @TomShawn
Update user-defined-variables.md
022e481 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 25, 2021

/lgtm

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Apr 25, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 25, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 25, 2021

/label require-LGT1

@ti-chi-bot ti-chi-bot added the require-LGT1 Indicates that the PR requires an LGTM. label Apr 25, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 25, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Apr 25, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 022e481

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 25, 2021
@ti-chi-bot ti-chi-bot merged commit 9c1f992 into pingcap:master Apr 25, 2021
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Apr 25, 2021
@Liuxiaozhen12 @ti-srebot
cherry pick pingcap#6062 to release-5.0
9d83520 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 25, 2021
Merged
11 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Apr 25, 2021

cherry pick to release-5.0 in PR #6137

ti-chi-bot pushed a commit that referenced this pull request Apr 25, 2021
@ti-srebot
add MySQL compatibility in user-defined-variables.md (#6062) (#6137)
a1b755c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

1 more reviewer

@TomShawn TomShawn TomShawn left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs This PR is translated from a PR in pingcap/docs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Liuxiaozhen12 @CLAassistant @Joyinqin @TomShawn @ti-chi-bot @ti-srebot