Skip to content

user-defined-variables: Add note about SELECT...INTO <var>#5268

Merged
ti-chi-bot merged 2 commits into
pingcap:masterfrom
dveeden:dvaneeden/udv_mysql_compat
Apr 19, 2021
Merged

user-defined-variables: Add note about SELECT...INTO <var>#5268
ti-chi-bot merged 2 commits into
pingcap:masterfrom
dveeden:dvaneeden/udv_mysql_compat

Conversation

@dveeden
Copy link
Copy Markdown
Contributor

@dveeden dveeden commented Apr 8, 2021

What is changed, added or deleted? (Required)

user-defined-variables: Add note about SELECT...INTO

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 8, 2021
morgo
morgo reviewed Apr 8, 2021
View reviewed changes
Comment thread user-defined-variables.md Outdated
Comment thread user-defined-variables.md Outdated
@dveeden dveeden force-pushed the dvaneeden/udv_mysql_compat branch from d55a891 to c8ef490 Compare April 8, 2021 16:25
@morgo
Copy link
Copy Markdown
Contributor

morgo commented Apr 8, 2021

/LGTM

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Apr 8, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • morgo

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 8, 2021
@dveeden
Copy link
Copy Markdown
Contributor Author

dveeden commented Apr 16, 2021

@morgo what's needed to get this merged?

@morgo
Copy link
Copy Markdown
Contributor

morgo commented Apr 16, 2021

@dveeden We have two reviewers: technical review (me) and language review.

/cc @TomShawn

@ti-chi-bot ti-chi-bot requested a review from TomShawn April 16, 2021 13:41
TomShawn
TomShawn reviewed Apr 19, 2021
View reviewed changes
Comment thread user-defined-variables.md Outdated
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 19, 2021

/label needs-cherry-pick-5.0
/translation doing
/assign Joyinqin
/label require-LGT1

@ti-chi-bot ti-chi-bot added translation/doing This PR's assignee is translating this PR. needs-cherry-pick-5.0 require-LGT1 Indicates that the PR requires an LGTM. and removed missing-translation-status This PR does not have translation status info. labels Apr 19, 2021
@dveeden @TomShawn
Update user-defined-variables.md
290965d 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 19, 2021

/lgtm

@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 19, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Apr 19, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 290965d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 19, 2021
@ti-chi-bot ti-chi-bot merged commit 3e1ac17 into pingcap:master Apr 19, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 19, 2021
@dveeden @ti-srebot
cherry pick pingcap#5268 to release-5.0
a5b200c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 19, 2021
Merged
10 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Apr 19, 2021

cherry pick to release-5.0 in PR #5393

@Joyinqin
Copy link
Copy Markdown
Contributor

Joyinqin commented Apr 19, 2021

/assign @Liuxiaozhen12
/unassign @Joyinqin

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Apr 19, 2021

@Joyinqin: GitHub didn't allow me to assign the following users: Liuxiaozhen12.

Note that only pingcap members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

/assign @Liuxiaozhen12
/unassign @Joyinqin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot pushed a commit that referenced this pull request Apr 19, 2021
@ti-srebot
user-defined-variables: Add note about SELECT...INTO <var> (#5268) (#…
caef015 
…5393)
@Liuxiaozhen12 Liuxiaozhen12 mentioned this pull request Apr 19, 2021
Merged
11 tasks
@Liuxiaozhen12
Copy link
Copy Markdown
Contributor

Liuxiaozhen12 commented Apr 19, 2021

/translation done

@ti-chi-bot ti-chi-bot added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Apr 19, 2021
@Liuxiaozhen12
Copy link
Copy Markdown
Contributor

Liuxiaozhen12 commented Apr 19, 2021

/remove-translation doing

@ti-chi-bot ti-chi-bot removed the translation/doing This PR's assignee is translating this PR. label Apr 19, 2021
@ti-srebot ti-srebot mentioned this pull request Apr 25, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@morgo morgo morgo left review comments

@TomShawn TomShawn TomShawn left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@dveeden @morgo @ti-chi-bot @TomShawn @ti-srebot @Joyinqin @Liuxiaozhen12