Skip to content

update docs related to partition table dynamic mode#6467

Merged
ti-chi-bot merged 24 commits into
pingcap:masterfrom
qw4990:partition-dynamic-mode
Jun 18, 2021
Merged

update docs related to partition table dynamic mode#6467
ti-chi-bot merged 24 commits into
pingcap:masterfrom
qw4990:partition-dynamic-mode

Conversation

@qw4990
Copy link
Copy Markdown
Contributor

@qw4990 qw4990 commented Jun 17, 2021

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@qw4990 qw4990 requested review from lysu, rebelice and tiancaiamao June 17, 2021 09:17
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 17, 2021
Copy link
Copy Markdown
Contributor

@rebelice rebelice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Copy Markdown
Member

@rebelice: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 17, 2021
@lysu lysu added the v5.1 This PR/issue applies to TiDB v5.1. label Jun 17, 2021
@lysu
Copy link
Copy Markdown
Contributor

lysu commented Jun 17, 2021

please fix lint~

@qiancai qiancai requested a review from TomShawn June 17, 2021 09:49
@TomShawn TomShawn added the translation/doing This PR’s assignee is translating this PR. label Jun 17, 2021
Comment thread experimental-features.md Outdated
@ti-chi-bot
Copy link
Copy Markdown
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lysu
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 17, 2021
qw4990 and others added 2 commits June 17, 2021 17:54
Co-authored-by: Grace Cai <qqzczy@126.com>
@qw4990
Copy link
Copy Markdown
Contributor Author

qw4990 commented Jun 17, 2021

@lysu updated. Please approve it again~

@TomShawn TomShawn removed the missing-translation-status This PR does not have translation status info. label Jun 17, 2021
Comment thread partitioned-table.md Outdated
Comment thread partitioned-table.md Outdated
Comment thread partitioned-table.md
Comment thread partitioned-table.md Outdated
Comment thread partitioned-table.md Outdated
Comment thread partitioned-table.md Outdated
Comment thread system-variables.md Outdated
Comment thread system-variables.md Outdated
Comment thread partitioned-table.md Outdated
Comment thread partitioned-table.md
qw4990 and others added 2 commits June 17, 2021 20:23
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
qw4990 and others added 4 commits June 17, 2021 20:26
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@qw4990
Copy link
Copy Markdown
Contributor Author

qw4990 commented Jun 17, 2021

已更新,辛苦再 review 一下 @TomShawn

Comment thread partitioned-table.md Outdated
Comment thread partitioned-table.md Outdated
Comment thread partitioned-table.md Outdated
Comment thread partitioned-table.md Outdated
Comment thread partitioned-table.md Outdated
Comment thread partitioned-table.md Outdated
Comment thread partitioned-table.md Outdated
Comment thread partitioned-table.md Outdated
Comment thread partitioned-table.md Outdated
Comment thread partitioned-table.md Outdated
qw4990 and others added 11 commits June 18, 2021 10:49
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn
Copy link
Copy Markdown
Contributor

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 547f7a0

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 18, 2021
@ti-chi-bot ti-chi-bot merged commit 49cb258 into pingcap:master Jun 18, 2021
@Liuxiaozhen12
Copy link
Copy Markdown
Contributor

/remove-translation doing
/translation done

@ti-chi-bot ti-chi-bot added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jun 18, 2021
3AceShowHand pushed a commit to 3AceShowHand/docs-cn that referenced this pull request Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v5.1 This PR/issue applies to TiDB v5.1.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants