Skip to content

update docs related to partition table dynamic mode#5810

Merged
ti-chi-bot merged 4 commits into
pingcap:masterfrom
Liuxiaozhen12:Liuxiaozhen-patch-8
Jun 21, 2021
Merged

update docs related to partition table dynamic mode#5810
ti-chi-bot merged 4 commits into
pingcap:masterfrom
Liuxiaozhen12:Liuxiaozhen-patch-8

Conversation

@Liuxiaozhen12
Copy link
Copy Markdown
Contributor

@Liuxiaozhen12 Liuxiaozhen12 commented Jun 18, 2021 •
edited
Loading

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot requested a review from TomShawn June 18, 2021 07:59
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 18, 2021
@Liuxiaozhen12 Liuxiaozhen12 requested a review from qw4990 June 18, 2021 08:00
@Liuxiaozhen12
Copy link
Copy Markdown
Contributor Author

Liuxiaozhen12 commented Jun 18, 2021

/label v5.1
/translation from-docs-cn

@ti-chi-bot ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v5.1 This PR/issue applies to TiDB v5.1. and removed missing-translation-status This PR does not have translation status info. labels Jun 18, 2021
TomShawn
TomShawn reviewed Jun 18, 2021
View reviewed changes
Comment thread experimental-features.md Outdated
Comment thread partitioned-table.md Outdated
Comment thread partitioned-table.md Outdated
Comment thread partitioned-table.md Outdated
Comment thread partitioned-table.md Outdated
Comment thread partitioned-table.md Outdated
Comment thread partitioned-table.md Outdated
Comment thread partitioned-table.md Outdated
Comment thread partitioned-table.md Outdated
Comment thread system-variables.md Outdated
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 21, 2021

@qw4990: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

TomShawn
TomShawn reviewed Jun 21, 2021
View reviewed changes
Comment thread partitioned-table.md Outdated
TomShawn
TomShawn approved these changes Jun 21, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 21, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 21, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jun 21, 2021

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 21, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jun 21, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 21, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: c78077d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 21, 2021
@ti-chi-bot ti-chi-bot merged commit 3098559 into pingcap:master Jun 21, 2021
@Liuxiaozhen12 Liuxiaozhen12 deleted the Liuxiaozhen-patch-8 branch June 25, 2021 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qw4990 qw4990 qw4990 approved these changes

+1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v5.1 This PR/issue applies to TiDB v5.1.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Liuxiaozhen12 @ti-chi-bot @TomShawn @qw4990