Skip to content

stale-read: adjust the TOC#6476

Merged
ti-chi-bot merged 3 commits into
pingcap:masterfrom
nolouch:adjust-stale-read
Jun 23, 2021
Merged

stale-read: adjust the TOC#6476
ti-chi-bot merged 3 commits into
pingcap:masterfrom
nolouch:adjust-stale-read

Conversation

@nolouch
Copy link
Copy Markdown
Member

@nolouch nolouch commented Jun 21, 2021

Signed-off-by: nolouch nolouch@gmail.com

First-time contributors' checklist

What is changed, added or deleted? (Required)

adjust the TOC

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@nolouch
adjust the TOC
8cda1cf 
Signed-off-by: nolouch <nolouch@gmail.com>
@ti-chi-bot ti-chi-bot requested a review from TomShawn June 21, 2021 05:38
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 21, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 21, 2021

@JmPotato: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 21, 2021
TomShawn
TomShawn approved these changes Jun 21, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 21, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • Yisaer

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 21, 2021
@TomShawn TomShawn added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Jun 21, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Jun 21, 2021
@TomShawn TomShawn mentioned this pull request Jun 21, 2021
Merged
11 tasks
@nolouch
Copy link
Copy Markdown
Member Author

nolouch commented Jun 21, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 21, 2021

@nolouch: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jun 23, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 23, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: b403d99

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 23, 2021
@ti-chi-bot ti-chi-bot merged commit f564131 into pingcap:master Jun 23, 2021
This was referenced Jun 23, 2021
Merged
Merged
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 23, 2021

In response to a cherrypick label: new pull request created: #6506.

ti-chi-bot added a commit that referenced this pull request Jun 23, 2021
@ti-chi-bot
stale-read: adjust the TOC (#6476) (#6506)
c4e60a9
3AceShowHand pushed a commit to 3AceShowHand/docs-cn that referenced this pull request Jul 27, 2021
@nolouch @3AceShowHand
stale-read: adjust the TOC (pingcap#6476)
6547c72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@JmPotato JmPotato JmPotato approved these changes

@Yisaer Yisaer Yisaer approved these changes

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@CharLotteiu CharLotteiu

Labels

size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@nolouch @ti-chi-bot @TomShawn @JmPotato @Yisaer @CharLotteiu