Skip to content

TiKV configuration: add a backtick#6694

Closed
Liuxiaozhen12 wants to merge 2 commits into
pingcap:masterfrom
Liuxiaozhen12:TiKVconfigurationfix
Closed

TiKV configuration: add a backtick#6694
Liuxiaozhen12 wants to merge 2 commits into
pingcap:masterfrom
Liuxiaozhen12:TiKVconfigurationfix

Conversation

@Liuxiaozhen12
Copy link
Copy Markdown
Contributor

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Copy Markdown
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn July 16, 2021 10:00
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 16, 2021
@Liuxiaozhen12 Liuxiaozhen12 added needs-cherry-pick-release-5.0 translation/from-docs This PR is translated from a PR in pingcap/docs. labels Jul 16, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Jul 16, 2021
@Liuxiaozhen12 Liuxiaozhen12 requested a review from yiwu-arbug July 16, 2021 10:03
@ti-chi-bot
Copy link
Copy Markdown
Member

@yiwu-arbug: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Aug 5, 2021

@Liuxiaozhen12 pingcap/docs#5936 should be aligned after other PRs. @en-jin19 will take care of these PRs.

@TomShawn TomShawn closed this Aug 5, 2021
@TomShawn TomShawn removed needs-cherry-pick-release-5.0 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/from-docs This PR is translated from a PR in pingcap/docs. labels Aug 5, 2021
@ti-chi-bot ti-chi-bot added the missing-translation-status This PR does not have translation status info. label Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-translation-status This PR does not have translation status info.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants