Skip to content

TiKV configuration: defaultcf.titan config should not apply to other CFs#5936

Merged
ti-chi-bot merged 2 commits into
pingcap:masterfrom
yiwu-arbug:titan
Jul 8, 2021
Merged

TiKV configuration: defaultcf.titan config should not apply to other CFs#5936
ti-chi-bot merged 2 commits into
pingcap:masterfrom
yiwu-arbug:titan

Conversation

@yiwu-arbug
Copy link
Copy Markdown
Contributor

@yiwu-arbug yiwu-arbug commented Jul 7, 2021 •
edited by TomShawn
Loading

Signed-off-by: Yi Wu yiwu@pingcap.com

First-time contributors' checklist

What is changed, added or deleted? (Required)

Titan only works on the defaultcf. The rocksdb.defaultcf.titan configs do not apply to writecf and lockcf. Fixing it. It looks like the Chinese version doesn't have such mistake.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot requested a review from TomShawn July 7, 2021 21:50
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 7, 2021
@yiwu-arbug
Copy link
Copy Markdown
Contributor Author

yiwu-arbug commented Jul 7, 2021

formatting fix
05fb9bb 
Signed-off-by: Yi Wu <yiwu@pingcap.com>
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 8, 2021

@tabokie: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

TomShawn
TomShawn approved these changes Jul 8, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 8, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 8, 2021
@TomShawn TomShawn added needs-cherry-pick-release-5.0 translation/doing This PR's assignee is translating this PR. labels Jul 8, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Jul 8, 2021
@TomShawn TomShawn assigned en-jin19 and Liuxiaozhen12 and unassigned en-jin19 Jul 8, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jul 8, 2021

@yiwu-arbug @tabokie If rocksdb.writecf.titan and rocksdb.lockcf.titan are removed, these two configs will have no user document. Is that expected?

@tabokie
Copy link
Copy Markdown
Contributor

tabokie commented Jul 8, 2021

@TomShawn Yes, we don't encourage using it.

@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jul 8, 2021

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 8, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jul 8, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 8, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 05fb9bb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 8, 2021
@ti-chi-bot ti-chi-bot merged commit 3d38ff6 into pingcap:master Jul 8, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 8, 2021
Merged
12 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 8, 2021

In response to a cherrypick label: new pull request created: #5943.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 8, 2021
Merged
12 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 8, 2021

In response to a cherrypick label: new pull request created: #5944.

ti-chi-bot added a commit that referenced this pull request Jul 8, 2021
@ti-chi-bot
TiKV configuration: defaultcf.titan config should not apply to other …
2dfc3fa 
…CFs (#5936) (#5943)
ti-chi-bot added a commit that referenced this pull request Jul 8, 2021
@ti-chi-bot
TiKV configuration: defaultcf.titan config should not apply to other …
f7a9e0f 
…CFs (#5936) (#5944)
@Liuxiaozhen12 Liuxiaozhen12 mentioned this pull request Jul 16, 2021
Closed
11 tasks
@Liuxiaozhen12 Liuxiaozhen12 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Jul 16, 2021
@TomShawn TomShawn assigned en-jin19 and unassigned Liuxiaozhen12 Aug 5, 2021
@TomShawn TomShawn added translation/doing This PR's assignee is translating this PR. and removed translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. labels Aug 5, 2021
@en-jin19 en-jin19 mentioned this pull request Aug 5, 2021
Merged
11 tasks
@en-jin19 en-jin19 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Aug 5, 2021
This was referenced Aug 6, 2021
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@tabokie tabokie tabokie approved these changes

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@en-jin19 en-jin19

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@yiwu-arbug @ti-chi-bot @TomShawn @tabokie @en-jin19 @Liuxiaozhen12