Skip to content

TiKV configuration: integrate writecf and lockcf to one part with defaultcf#6816

Merged
ti-chi-bot merged 4 commits into
pingcap:masterfrom
en-jin19:TiKV-configuration-Overhauling-TiKV-RocksDB-configuration-file
Aug 6, 2021
Merged

TiKV configuration: integrate writecf and lockcf to one part with defaultcf#6816
ti-chi-bot merged 4 commits into
pingcap:masterfrom
en-jin19:TiKV-configuration-Overhauling-TiKV-RocksDB-configuration-file

Conversation

@en-jin19
Copy link
Copy Markdown
Contributor

@en-jin19 en-jin19 commented Aug 5, 2021

What is changed, added or deleted? (Required)

integrated rockdb.writecf and rockdb.lockcf in one part with defaultcf

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from: #5746, #5936.
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@en-jin19 en-jin19 added translation/from-docs This PR is translated from a PR in pingcap/docs. needs-cherry-pick-release-3.1 labels Aug 5, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Aug 5, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 5, 2021
@en-jin19 en-jin19 requested review from TomShawn and yiwu-arbug August 5, 2021 20:42
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 6, 2021
@TomShawn TomShawn added require-LGT1 Indicates that the PR requires an LGTM. and removed needs-cherry-pick-release-3.1 labels Aug 6, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Aug 6, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 60d07e7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 6, 2021
@ti-chi-bot ti-chi-bot merged commit 4f93467 into pingcap:master Aug 6, 2021
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Aug 6, 2021
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created: #6821.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Aug 6, 2021
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created: #6822.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Aug 6, 2021
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created: #6823.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

require-LGT1 Indicates that the PR requires an LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs This PR is translated from a PR in pingcap/docs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants