Skip to content

system variables: add charset documentation#6712

Merged
ti-chi-bot merged 3 commits into
pingcap:masterfrom
en-jin19:system-variables-Add-charset-documentation
Jul 27, 2021
Merged

system variables: add charset documentation#6712
ti-chi-bot merged 3 commits into
pingcap:masterfrom
en-jin19:system-variables-Add-charset-documentation

Conversation

@en-jin19
Copy link
Copy Markdown
Contributor

@en-jin19 en-jin19 commented Jul 21, 2021

What is changed, added or deleted? (Required)

added charset documentation in system-variables document

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from: #5867
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@en-jin19 en-jin19 added translation/from-docs This PR is translated from a PR in pingcap/docs. needs-cherry-pick-release-5.0 labels Jul 21, 2021
@en-jin19 en-jin19 requested a review from TomShawn July 21, 2021 21:57
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 21, 2021
@en-jin19
Copy link
Copy Markdown
Contributor Author

en-jin19 commented Jul 21, 2021

I have finished self-check, please take a look, thanks! @TomShawn

@TomShawn TomShawn requested a review from bb7133 July 22, 2021 02:23
TomShawn
TomShawn reviewed Jul 22, 2021
View reviewed changes
Comment thread system-variables.md Outdated
Comment thread system-variables.md Outdated
Comment thread system-variables.md Outdated
Comment thread system-variables.md Outdated
Comment thread system-variables.md Outdated
Comment thread system-variables.md Outdated
@TomShawn TomShawn requested a review from wjhuang2016 July 22, 2021 11:52
@TomShawn TomShawn added the status/require-change Needs the author to address comments. label Jul 22, 2021
en-jin19 and others added 2 commits July 23, 2021 10:11
@en-jin19 @TomShawn
Apply suggestions from code review
0ec9be0 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@en-jin19 @TomShawn
Update system-variables.md
35df6d7 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 27, 2021

@wjhuang2016: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn TomShawn removed the status/require-change Needs the author to address comments. label Jul 27, 2021
TomShawn
TomShawn approved these changes Jul 27, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 27, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 27, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jul 27, 2021

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 27, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jul 27, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 27, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 35df6d7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 27, 2021
@ti-chi-bot ti-chi-bot merged commit 45f564c into pingcap:master Jul 27, 2021
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Jul 27, 2021
@en-jin19 @ti-chi-bot
This is an automated cherry-pick of pingcap#6712
711ddfa 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 27, 2021

In response to a cherrypick label: new pull request created: #6735.

This was referenced Jul 27, 2021
Merged
Merged
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 27, 2021

In response to a cherrypick label: new pull request created: #6736.

ti-chi-bot added a commit that referenced this pull request Jul 27, 2021
@ti-chi-bot
system variables: add charset documentation (#6712) (#6736)
617132d
ti-chi-bot added a commit that referenced this pull request Jul 27, 2021
@ti-chi-bot
system variables: add charset documentation (#6712) (#6735)
4796f0e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

@bb7133 bb7133 Awaiting requested review from bb7133

+1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs This PR is translated from a PR in pingcap/docs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@en-jin19 @ti-chi-bot @TomShawn @wjhuang2016