system-variables: Add charset documentation by dveeden · Pull Request #5867 · pingcap/docs

dveeden · 2021-06-27T21:10:31Z

What is changed, added or deleted? (Required)

Add documentation for these:

5.7.25-TiDB-v5.2.0-alpha-164-g8434069c5 127.0.0.1:4000  test  SQL  show global variables like 'char%';
+--------------------------+--------------------------------------------------------+
| Variable_name            | Value                                                  |
+--------------------------+--------------------------------------------------------+
| character_set_client     | utf8mb4                                                |
| character_set_connection | utf8mb4                                                |
| character_set_database   | utf8mb4                                                |
| character_set_filesystem | binary                                                 |
| character_set_results    | utf8mb4                                                |
| character_set_server     | utf8mb4                                                |
| character_set_system     | utf8                                                   |
| character_sets_dir       | /usr/local/mysql-5.6.25-osx10.8-x86_64/share/charsets/ |
+--------------------------+--------------------------------------------------------+
8 rows in set (0.0042 sec)

Which TiDB version(s) do your changes apply to? (Required)

Related to #3155

pingcap/docs#5867 (comment)

Co-authored-by: bb7133 <bb7133@gmail.com>

ti-chi-bot · 2021-07-01T05:24:25Z

@bb7133: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

bb7133 · 2021-07-01T05:24:29Z

/merge

ti-chi-bot · 2021-07-01T05:24:31Z

@bb7133: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

dveeden · 2021-07-01T07:02:30Z

/assign @morgo @TomShawn

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

TomShawn

LGTM

ti-chi-bot · 2021-07-01T11:32:22Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

TomShawn
morgo

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

TomShawn · 2021-07-01T11:32:29Z

/merge

ti-chi-bot · 2021-07-01T11:32:30Z

This pull request has been accepted and is ready to merge.

Details

Commit hash: f950f6c

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot · 2021-07-01T11:34:05Z

In response to a cherrypick label: new pull request created: #5908.

ti-chi-bot · 2021-07-01T11:34:43Z

In response to a cherrypick label: new pull request created: #5909.

dveeden requested a review from morgo June 27, 2021 21:10

ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 27, 2021

morgo reviewed Jun 27, 2021

View reviewed changes

Comment thread system-variables.md Outdated

TomShawn requested review from bb7133 and wjhuang2016 June 28, 2021 03:54

system-variables: Add charset documentation

4cbf744

dveeden force-pushed the charset branch from cb55bbb to 4cbf744 Compare June 28, 2021 06:17

dveeden added a commit to dveeden/tidb that referenced this pull request Jun 28, 2021

sessionctx: Move CharacterSetFilesystem from sysvar.go to noop.go

5ff96de

pingcap/docs#5867 (comment)

dveeden mentioned this pull request Jun 28, 2021

variable: Move CharacterSetFilesystem from sysvar.go to noop.go pingcap/tidb#25793

Merged

bb7133 reviewed Jun 29, 2021

View reviewed changes

Comment thread system-variables.md Outdated

Update system-variables.md

79ff3a7

Co-authored-by: bb7133 <bb7133@gmail.com>

dveeden requested review from bb7133 and morgo June 29, 2021 09:56

morgo approved these changes Jun 29, 2021

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 29, 2021

bb7133 approved these changes Jul 1, 2021

View reviewed changes

ti-chi-bot assigned morgo and TomShawn Jul 1, 2021

TomShawn unassigned morgo Jul 1, 2021

TomShawn added the translation/doing This PR's assignee is translating this PR. label Jul 1, 2021

ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Jul 1, 2021

TomShawn added needs-cherry-pick-release-5.0 labels Jul 1, 2021

TomShawn removed their assignment Jul 1, 2021

TomShawn assigned en-jin19 Jul 1, 2021

TomShawn reviewed Jul 1, 2021

View reviewed changes

Comment thread system-variables.md Outdated

Comment thread system-variables.md Outdated

Comment thread system-variables.md Outdated

Comment thread system-variables.md Outdated

dveeden and others added 4 commits July 1, 2021 09:29

Update system-variables.md

c773f94

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

Update system-variables.md

6eb8dd7

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

Update system-variables.md

e7a495c

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

Update system-variables.md

f950f6c

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

TomShawn approved these changes Jul 1, 2021

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 1, 2021

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 1, 2021

ti-chi-bot merged commit 79f4f71 into pingcap:master Jul 1, 2021

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Jul 1, 2021

This is an automated cherry-pick of pingcap#5867

30bad9d

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request Jul 1, 2021

system-variables: Add charset documentation (#5867) #5908

Merged

7 tasks

ti-chi-bot mentioned this pull request Jul 1, 2021

system-variables: Add charset documentation (#5867) #5909

Merged

7 tasks

ti-chi-bot added a commit that referenced this pull request Jul 1, 2021

system-variables: Add charset documentation (#5867) (#5909)

f5baca7

ti-chi-bot added a commit that referenced this pull request Jul 2, 2021

system-variables: Add charset documentation (#5867) (#5908)

aff2a73

en-jin19 mentioned this pull request Jul 21, 2021

system variables: add charset documentation pingcap/docs-cn#6712

Merged

11 tasks

en-jin19 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Jul 21, 2021

This was referenced Jul 27, 2021

system variables: add charset documentation (#6712) pingcap/docs-cn#6735

Merged

system variables: add charset documentation (#6712) pingcap/docs-cn#6736

Merged

Conversation

dveeden commented Jun 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Uh oh!

Uh oh!

Uh oh!

ti-chi-bot commented Jul 1, 2021

Uh oh!

bb7133 commented Jul 1, 2021

Uh oh!

ti-chi-bot commented Jul 1, 2021

Uh oh!

dveeden commented Jul 1, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TomShawn left a comment

Choose a reason for hiding this comment

Uh oh!

ti-chi-bot commented Jul 1, 2021

Uh oh!

TomShawn commented Jul 1, 2021

Uh oh!

ti-chi-bot commented Jul 1, 2021

Uh oh!

ti-chi-bot commented Jul 1, 2021

Uh oh!

ti-chi-bot commented Jul 1, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

dveeden commented Jun 27, 2021 •

edited

Loading