Skip to content

*: Add TiDB Dashboard session docs (#6711)#6729

Merged
ti-chi-bot merged 13 commits into
pingcap:release-5.0from
ti-chi-bot:cherry-pick-6711-to-release-5.0
Sep 27, 2021
Merged

*: Add TiDB Dashboard session docs (#6711)#6729
ti-chi-bot merged 13 commits into
pingcap:release-5.0from
ti-chi-bot:cherry-pick-6711-to-release-5.0

Conversation

@ti-chi-bot
Copy link
Copy Markdown
Member

@ti-chi-bot ti-chi-bot commented Jul 23, 2021

This is an automated cherry-pick of #6711

Signed-off-by: Breezewish me@breeswish.org

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add TiDB Dashboard docs about sessions.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions) Version number needs change
  • v5.0 (TiDB 5.0 versions) Version number needs change
  • v4.0 (TiDB 4.0 versions) Version number needs change
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Copy Markdown
Member Author

ti-chi-bot commented Jul 23, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • breeswish

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 23, 2021
Merged
12 tasks
@ti-chi-bot ti-chi-bot added requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR. labels Jul 23, 2021
@ti-chi-bot ti-chi-bot requested a review from TomShawn July 23, 2021 09:51
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jul 23, 2021

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 23, 2021
breezewish
breezewish reviewed Jul 23, 2021
View reviewed changes
Comment thread dashboard/dashboard-session-share.md Outdated
breezewish
breezewish reviewed Jul 23, 2021
View reviewed changes
Comment thread dashboard/dashboard-session-sso.md
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 4, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Sep 15, 2021

This PR should also incorporate the changes made in #7131. @baurine

@baurine
Copy link
Copy Markdown
Contributor

baurine commented Sep 16, 2021 •
edited
Loading

This PR should also incorporate the changes made in #7131. @baurine

Done, please check @TomShawn .

@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Sep 27, 2021

/rebase

breezewish and others added 11 commits September 27, 2021 05:02
@github-actions github-actions Bot force-pushed the cherry-pick-6711-to-release-5.0 branch from 5e54c82 to 3dd8ace Compare September 27, 2021 05:02
@TomShawn TomShawn removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 27, 2021
TomShawn
TomShawn reviewed Sep 27, 2021
View reviewed changes
Comment thread dashboard/dashboard-session-sso.md
TomShawn
TomShawn reviewed Sep 27, 2021
View reviewed changes
Comment thread dashboard/dashboard-session-sso.md Outdated
TomShawn
TomShawn approved these changes Sep 27, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Sep 27, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member Author

ti-chi-bot commented Sep 27, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 6131290

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 27, 2021
@ti-chi-bot ti-chi-bot merged commit 6d7eca1 into pingcap:release-5.0 Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@breezewish breezewish breezewish approved these changes

+1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@breezewish breezewish

Labels

requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ti-chi-bot @TomShawn @baurine @breezewish