*: Add use Auth0 as example to login dashboard by sso by baurine · Pull Request #7093 · pingcap/docs-cn

baurine · 2021-09-09T06:51:27Z

What is changed, added or deleted? (Required)

Add use Auth0 as a new example to login TiDB Dashboard by SSO.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

What is the related PR or file link(s)?

This PR is translated from:
Other reference link(s):

Do your changes match any of the following descriptions?

Delete files
Change aliases
Need modification after applied to another branch
Might cause conflicts after applied to another branch

ti-chi-bot · 2021-09-09T06:51:28Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

TomShawn
breeswish

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

breezewish

Generally looks great! This is a good supplyment!

breezewish · 2021-09-09T08:55:57Z

+
+### 步骤二：获取 TiDB Dashboard 所需的配置参数并填入 TiDB Dashboard
+
+1. 将 Auth0 **Settings** 栏 **Basic Information** 项的 **Client ID** 字段的值填入 TiDB Dashboard 的 **OIDC Client ID**，将 **Domain** 字段的值，加上 `https://` 前缀和 `/` 后缀后填入 **OIDC Discovery URL** 中。完成授权并保存配置即可。


I guess the / suffix is optional. I'm not sure. You may have a try :)

I have tried, miss the / will report an error, maybe we can add it automatically? but maybe okta doesn't need to end with /, let me check.

Yep, auth0 needs but okta doesn't need.

It's a wired behaviour. Maybe we should revisit the implementation.

ok, let me check.

CLAassistant · 2021-09-15T02:44:39Z

All committers have signed the CLA.

Change the link for Auth0 from www.okta.com to auth0.com.

TomShawn

LGTM

TomShawn · 2021-09-15T06:12:25Z

/merge

ti-chi-bot · 2021-09-15T06:12:27Z

This pull request has been accepted and is ready to merge.

Details

Commit hash: 2b829ad

ti-chi-bot · 2021-09-15T06:17:18Z

In response to a cherrypick label: new pull request created: #7130.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot · 2021-09-15T06:17:55Z

In response to a cherrypick label: new pull request created: #7131.

ti-chi-bot · 2021-09-15T06:18:31Z

In response to a cherrypick label: new pull request created: #7132.

ti-chi-bot · 2021-09-15T06:19:07Z

In response to a cherrypick label: new pull request created: #7133.

ti-chi-bot requested a review from TomShawn September 9, 2021 06:51

ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 9, 2021

baurine mentioned this pull request Sep 9, 2021

Add example to use Auth0 as sso login option in the doc pingcap/tidb-dashboard#993

Closed

*: Add use Auth0 as example to login dashboard by sso

319ca1d

baurine force-pushed the update-dashboard-sso branch from 3f46c4b to 319ca1d Compare September 9, 2021 06:54

TomShawn requested a review from breezewish September 9, 2021 07:17

TomShawn assigned shichun-0415 Sep 9, 2021

TomShawn added translation/doing This PR’s assignee is translating this PR. needs-cherry-pick-release-4.0 sig/docs Indicates that the Issue or PR belongs to the docs SIG. and removed missing-translation-status This PR does not have translation status info. labels Sep 9, 2021

breezewish reviewed Sep 9, 2021

View reviewed changes

refine

d62b5b9

shichun-0415 reviewed Sep 14, 2021

View reviewed changes

Comment thread dashboard/dashboard-session-sso.md Outdated

Merge remote-tracking branch 'upstream/master' into update-dashboard-sso

26ca66b

Update dashboard-session-sso.md

d917156

Change the link for Auth0 from www.okta.com to auth0.com.

shichun-0415 mentioned this pull request Sep 15, 2021

Add use auth0 as example to login dashboard by sso pingcap/docs#6483

Merged

13 tasks

breezewish approved these changes Sep 15, 2021

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 15, 2021

very minor wording fix

2b829ad

TomShawn approved these changes Sep 15, 2021

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 15, 2021

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 15, 2021

ti-chi-bot merged commit bb66e22 into master Sep 15, 2021

ti-chi-bot mentioned this pull request Sep 15, 2021

*: Add use Auth0 as example to login dashboard by sso (#7093) #7130

Merged

12 tasks

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Sep 15, 2021

This is an automated cherry-pick of pingcap#7093

df441f6

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request Sep 15, 2021

*: Add use Auth0 as example to login dashboard by sso (#7093) #7131

Closed

12 tasks

baurine deleted the update-dashboard-sso branch September 15, 2021 06:17

ti-chi-bot mentioned this pull request Sep 15, 2021

*: Add use Auth0 as example to login dashboard by sso (#7093) #7132

Merged

12 tasks

ti-chi-bot mentioned this pull request Sep 15, 2021

*: Add use Auth0 as example to login dashboard by sso (#7093) #7133

Merged

12 tasks

ti-chi-bot added a commit that referenced this pull request Sep 15, 2021

*: Add use Auth0 as example to login dashboard by sso (#7093) (#7130)

a63b285

ti-chi-bot added a commit that referenced this pull request Sep 15, 2021

*: Add use Auth0 as example to login dashboard by sso (#7093) (#7132)

54eae7d

ti-chi-bot added a commit that referenced this pull request Sep 15, 2021

*: Add use Auth0 as example to login dashboard by sso (#7093) (#7133)

e1ff078

baurine added a commit that referenced this pull request Sep 16, 2021

*: Add use Auth0 as example to login dashboard by sso (#7093)

5e54c82

github-actions Bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Sep 27, 2021

*: Add use Auth0 as example to login dashboard by sso (pingcap#7093)

3dd8ace

TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Oct 21, 2021


		### 步骤二：获取 TiDB Dashboard 所需的配置参数并填入 TiDB Dashboard

		1. 将 Auth0 Settings 栏 Basic Information 项的 Client ID 字段的值填入 TiDB Dashboard 的 OIDC Client ID，将 Domain 字段的值，加上 `https://` 前缀和 `/` 后缀后填入 OIDC Discovery URL 中。完成授权并保存配置即可。

Conversation

baurine commented Sep 9, 2021

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

Uh oh!

ti-chi-bot commented Sep 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

breezewish left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

breezewish Sep 9, 2021

Choose a reason for hiding this comment

Uh oh!

baurine Sep 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

baurine Sep 10, 2021

Choose a reason for hiding this comment

Uh oh!

breezewish Sep 10, 2021

Choose a reason for hiding this comment

Uh oh!

baurine Sep 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

CLAassistant commented Sep 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TomShawn left a comment

Choose a reason for hiding this comment

Uh oh!

TomShawn commented Sep 15, 2021

Uh oh!

ti-chi-bot commented Sep 15, 2021

Uh oh!

ti-chi-bot commented Sep 15, 2021

Uh oh!

ti-chi-bot commented Sep 15, 2021

Uh oh!

ti-chi-bot commented Sep 15, 2021

Uh oh!

ti-chi-bot commented Sep 15, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ti-chi-bot commented Sep 9, 2021 •

edited

Loading

baurine Sep 9, 2021 •

edited

Loading

baurine Sep 13, 2021 •

edited

Loading

CLAassistant commented Sep 15, 2021 •

edited

Loading