Skip to content

Add use auth0 as example to login dashboard by sso#6483

Merged
ti-chi-bot merged 4 commits into
pingcap:masterfrom
shichun-0415:Add-use-Auth0-as-example-to-login-dashboard-by-sso
Oct 21, 2021
Merged

Add use auth0 as example to login dashboard by sso#6483
ti-chi-bot merged 4 commits into
pingcap:masterfrom
shichun-0415:Add-use-Auth0-as-example-to-login-dashboard-by-sso

Conversation

@shichun-0415
Copy link
Copy Markdown
Contributor

@shichun-0415 shichun-0415 commented Sep 15, 2021

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add use auth0 as example to login dashboard by sso

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Sep 15, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn September 15, 2021 03:07
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 15, 2021
@shichun-0415 shichun-0415 added sig/docs Indicates that the Issue or PR belongs to the docs SIG. needs-cherry-pick-release-4.0 area/diagnosis Indicates that the Issue or PR belongs to the area of diagnosis and monitoring. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Sep 15, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Sep 15, 2021
@shichun-0415
Copy link
Copy Markdown
Contributor Author

shichun-0415 commented Sep 15, 2021

I've finished the self-check of this PR. PTAL

@TomShawn TomShawn added the status/WIP This PR is still working in progress. label Sep 15, 2021
baurine
baurine approved these changes Sep 16, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@baurine baurine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Sep 16, 2021

@baurine: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

TomShawn
TomShawn approved these changes Oct 11, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM
These are only minor comments. Good job!

Comment thread dashboard/dashboard-session-sso.md Outdated
Comment thread dashboard/dashboard-session-sso.md Outdated
Comment thread dashboard/dashboard-session-sso.md Outdated
Comment thread dashboard/dashboard-session-sso.md Outdated
Comment thread dashboard/dashboard-session-sso.md Outdated
Comment thread dashboard/dashboard-session-sso.md Outdated
Comment thread dashboard/dashboard-session-sso.md Outdated
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 11, 2021
@TomShawn TomShawn removed the status/WIP This PR is still working in progress. label Oct 11, 2021
@shichun-0415 @TomShawn
Apply suggestions from code review
114bc55 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Oct 21, 2021

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 21, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Oct 21, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Oct 21, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 114bc55

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 21, 2021
@ti-chi-bot ti-chi-bot merged commit 94830aa into pingcap:master Oct 21, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 21, 2021
Merged
13 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Oct 21, 2021

In response to a cherrypick label: new pull request created: #6658.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 21, 2021
Merged
13 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Oct 21, 2021

In response to a cherrypick label: new pull request created: #6659.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 21, 2021
Merged
13 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Oct 21, 2021

In response to a cherrypick label: new pull request created: #6660.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 21, 2021
Merged
13 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Oct 21, 2021

In response to a cherrypick label: new pull request created: #6661.

ti-chi-bot added a commit that referenced this pull request Oct 21, 2021
@ti-chi-bot
Add use auth0 as example to login dashboard by sso (#6483) (#6661)
56da327
ti-chi-bot added a commit that referenced this pull request Oct 21, 2021
@ti-chi-bot
Add use auth0 as example to login dashboard by sso (#6483) (#6660)
727572a
ti-chi-bot added a commit that referenced this pull request Oct 21, 2021
@ti-chi-bot
Add use auth0 as example to login dashboard by sso (#6483) (#6658)
c4a30f9
ti-chi-bot added a commit that referenced this pull request Oct 21, 2021
@ti-chi-bot
Add use auth0 as example to login dashboard by sso (#6483) (#6659)
67eedf3
@shichun-0415 shichun-0415 deleted the Add-use-Auth0-as-example-to-login-dashboard-by-sso branch November 25, 2021 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baurine baurine baurine approved these changes

+1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/diagnosis Indicates that the Issue or PR belongs to the area of diagnosis and monitoring. sig/docs Indicates that the Issue or PR belongs to the docs SIG. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shichun-0415 @ti-chi-bot @TomShawn @baurine