planner: update documents related to Plan Cache #8623

qw4990 · 2022-03-11T03:16:01Z

First-time contributors' checklist

I've signed Contributor License Agreement that's required for repo owners to accept my contribution.

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

What is the related PR or file link(s)?

This PR is translated from:
Other reference link(s):

Do your changes match any of the following descriptions?

Delete files
Change aliases
Need modification after applied to another branch
Might cause conflicts after applied to another branch

ti-chi-bot · 2022-03-11T03:16:02Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

qiancai
shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

TomShawn · 2022-03-11T05:54:13Z

@qw4990 Is this PR related to a v6.0 change? If yes, is there an FD JIRA for it?

TomShawn · 2022-03-14T02:47:58Z

/rebase

system-variables.md

sql-prepare-plan-cache.md

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

sql-prepare-plan-cache.md

Co-authored-by: Chengpeng Yan <41809508+Reminiscent@users.noreply.github.com>

Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>

shichun-0415

LGTM

sql-prepare-plan-cache.md

qiancai · 2022-03-17T11:22:39Z

system-variables.md

+- 作用域：SESSION | GLOBAL
+- 默认值：`OFF`
+- 这个变量用来设置是否忽略关闭 Prepared Statement 的指令。
+- 如果变量值设为 `ON`，Binary 协议的 `COM_STMT_CLOSE` 信号和文本协议的 `DEALLOCATE PREPARE` 语句都会被忽略。


这里可以加一个链接指向 “忽略 COM_STMT_CLOSE 指令和 DEALLOCATE PREPARE 语句” 这个章节吗？

COM_STMT_CLOSE 我们的文档内还没有相关内容；DEALLOCATE 的连接已经补充；

Co-authored-by: Grace Cai <qqzczy@126.com>

sql-prepare-plan-cache.md

Co-authored-by: Grace Cai <qqzczy@126.com>

sql-prepare-plan-cache.md

qiancai

LGTM

shichun-0415 · 2022-03-22T08:46:26Z

/merge

ti-chi-bot · 2022-03-22T08:46:29Z

This pull request has been accepted and is ready to merge.

Details

Commit hash: e77cd17

qw4990 requested review from Reminiscent and TomShawn March 11, 2022 03:16

ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 11, 2022

TomShawn self-assigned this Mar 11, 2022

TomShawn added translation/doing This PR’s assignee is translating this PR. area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. v6.0 This PR/issue applies to TiDB v6.0. labels Mar 11, 2022

ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Mar 11, 2022

qw4990 and others added 3 commits March 14, 2022 02:48

fixup

8e6540c

fixup

f070f0f

Update system-variables.md

f37bb01

TomShawn force-pushed the update-plan-cache branch from 58c9258 to f37bb01 Compare March 14, 2022 02:48

TomShawn reviewed Mar 14, 2022

View reviewed changes

system-variables.md Outdated Show resolved Hide resolved

TomShawn reviewed Mar 14, 2022

View reviewed changes

sql-prepare-plan-cache.md Outdated Show resolved Hide resolved

TomShawn reviewed Mar 14, 2022

View reviewed changes

sql-prepare-plan-cache.md Outdated Show resolved Hide resolved

TomShawn reviewed Mar 14, 2022

View reviewed changes

sql-prepare-plan-cache.md Outdated Show resolved Hide resolved

TomShawn reviewed Mar 14, 2022

View reviewed changes

sql-prepare-plan-cache.md Outdated Show resolved Hide resolved

qw4990 and others added 5 commits March 14, 2022 14:13

Update system-variables.md

9b6cb58

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

Update sql-prepare-plan-cache.md

e353fdc

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

Update sql-prepare-plan-cache.md

94130d4

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

Update sql-prepare-plan-cache.md

6e84249

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

Update sql-prepare-plan-cache.md

319bca0

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

Reminiscent reviewed Mar 14, 2022

View reviewed changes

sql-prepare-plan-cache.md Outdated Show resolved Hide resolved

qw4990 and others added 2 commits March 14, 2022 17:00

Update sql-prepare-plan-cache.md

5866b56

Co-authored-by: Chengpeng Yan <41809508+Reminiscent@users.noreply.github.com>

fixup

27d7fdd

Reminiscent approved these changes Mar 14, 2022

View reviewed changes

Update sql-prepare-plan-cache.md

2e19090

Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>

shichun-0415 approved these changes Mar 17, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 17, 2022

shichun-0415 requested review from qiancai and removed request for TomShawn March 17, 2022 08:22

qiancai reviewed Mar 17, 2022

View reviewed changes

qw4990 and others added 5 commits March 18, 2022 10:57

Update sql-prepare-plan-cache.md

cf3122c

Co-authored-by: Grace Cai <qqzczy@126.com>

Update sql-prepare-plan-cache.md

34c0b33

Co-authored-by: Grace Cai <qqzczy@126.com>

Update sql-prepare-plan-cache.md

78afc40

Co-authored-by: Grace Cai <qqzczy@126.com>

Update sql-prepare-plan-cache.md

993fca0

Co-authored-by: Grace Cai <qqzczy@126.com>

fixup

1697897

shichun-0415 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2022

qiancai reviewed Mar 21, 2022

View reviewed changes

sql-prepare-plan-cache.md Outdated Show resolved Hide resolved

Update sql-prepare-plan-cache.md

c1131a2

Co-authored-by: Grace Cai <qqzczy@126.com>

shichun-0415 reviewed Mar 22, 2022

View reviewed changes

sql-prepare-plan-cache.md Outdated Show resolved Hide resolved

Update sql-prepare-plan-cache.md

f8257dc

shichun-0415 reviewed Mar 22, 2022

View reviewed changes

sql-prepare-plan-cache.md Outdated Show resolved Hide resolved

fix CI

e77cd17

qiancai approved these changes Mar 22, 2022

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 22, 2022

ran-huang added the type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. label Mar 22, 2022

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 22, 2022

ti-chi-bot merged commit 2ec2553 into pingcap:master Mar 22, 2022

shichun-0415 mentioned this pull request Mar 27, 2022

update documents related to Plan Cache pingcap/docs#7956

Merged

16 tasks

shichun-0415 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Mar 27, 2022

ti-chi-bot mentioned this pull request Apr 1, 2022

update documents related to Plan Cache (#7956) pingcap/docs#8033

Merged

16 tasks

planner: update documents related to Plan Cache #8623

planner: update documents related to Plan Cache #8623

Uh oh!

Conversation

qw4990 commented Mar 11, 2022

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

Uh oh!

ti-chi-bot commented Mar 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TomShawn commented Mar 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TomShawn commented Mar 14, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shichun-0415 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

qiancai Mar 17, 2022

Choose a reason for hiding this comment

Uh oh!

qw4990 Mar 18, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

qiancai left a comment

Choose a reason for hiding this comment

Uh oh!

shichun-0415 commented Mar 22, 2022

Uh oh!

ti-chi-bot commented Mar 22, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

ti-chi-bot commented Mar 11, 2022 •

edited

Loading

TomShawn commented Mar 11, 2022 •

edited

Loading