Skip to content

update documents related to Plan Cache #7956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ti-chi-bot merged 9 commits into from
Apr 1, 2022
Merged

update documents related to Plan Cache #7956

ti-chi-bot merged 9 commits into from
Apr 1, 2022

Conversation

@shichun-0415
Copy link
Contributor

@shichun-0415 shichun-0415 commented Mar 27, 2022

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 27, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qiancai

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn March 27, 2022 15:06
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 27, 2022
@shichun-0415 shichun-0415 added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v6.0 This PR/issue applies to TiDB v6.0. and removed missing-translation-status This PR does not have translation status info. labels Mar 27, 2022
@shichun-0415 shichun-0415 requested review from qw4990 and removed request for TomShawn March 28, 2022 03:19
shichun-0415
shichun-0415 commented Mar 28, 2022
View reviewed changes
@shichun-0415
Copy link
Contributor Author

shichun-0415 commented Mar 28, 2022

/verify

qw4990
qw4990 reviewed Mar 29, 2022
View reviewed changes
qw4990
qw4990 approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

shichun-0415
shichun-0415 commented Mar 29, 2022
View reviewed changes
@shichun-0415 shichun-0415 requested a review from qiancai March 29, 2022 08:18
qiancai
qiancai reviewed Mar 31, 2022
View reviewed changes
@shichun-0415 @qiancai
Apply suggestions from code review
bcc1060 
Co-authored-by: Grace Cai <qqzczy@126.com>
shichun-0415
shichun-0415 commented Mar 31, 2022
View reviewed changes
shichun-0415
shichun-0415 commented Apr 1, 2022
View reviewed changes
shichun-0415
shichun-0415 commented Apr 1, 2022
View reviewed changes
qiancai
qiancai reviewed Apr 1, 2022
View reviewed changes
qiancai
qiancai approved these changes Apr 1, 2022
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 1, 2022
@shichun-0415 @qiancai
Update sql-prepare-plan-cache.md
f38f43f 
Co-authored-by: Grace Cai <qqzczy@126.com>
@shichun-0415
Copy link
Contributor Author

shichun-0415 commented Apr 1, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 1, 2022

@shichun-0415: /merge in this pull request requires 2 approval(s).

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@shichun-0415
Copy link
Contributor Author

shichun-0415 commented Apr 1, 2022

/remove status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Apr 1, 2022
@shichun-0415
Copy link
Contributor Author

shichun-0415 commented Apr 1, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 1, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: f38f43f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 1, 2022
@ti-chi-bot ti-chi-bot merged commit bf23c0a into pingcap:master Apr 1, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 1, 2022
Merged
16 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 1, 2022

In response to a cherrypick label: new pull request created: #8033.

@shichun-0415 shichun-0415 deleted the plan-cache branch April 1, 2022 11:45
ti-chi-bot added a commit that referenced this pull request Apr 1, 2022
@ti-chi-bot
update documents related to Plan Cache (#7956) (#8033)
11906db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qw4990 qw4990 qw4990 approved these changes

@qiancai qiancai qiancai approved these changes

Assignees

No one assigned

Labels

area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v6.0 This PR/issue applies to TiDB v6.0.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shichun-0415 @ti-chi-bot @qw4990 @qiancai