Skip to content

lightning: support base64 encoding of password #8624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ti-chi-bot merged 1 commit into from
Mar 21, 2022
Merged

lightning: support base64 encoding of password #8624

ti-chi-bot merged 1 commit into from
Mar 21, 2022

Conversation

@sleepymole
Copy link
Contributor

@sleepymole sleepymole commented Mar 11, 2022

First-time contributors' checklist

What is changed, added or deleted? (Required)

Lightning supports base64 encoding of password.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 11, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qiancai
  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn March 11, 2022 05:00
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 11, 2022
@sleepymole sleepymole requested review from hfxsd, qiancai and sunetic and removed request for TomShawn March 11, 2022 05:00
@TomShawn TomShawn added v6.0 This PR/issue applies to TiDB v6.0. translation/doing This PR’s assignee is translating this PR. area/tidb-lightning Indicates that the Issue or PR belongs to the area of TiDB Lightning. and removed missing-translation-status This PR does not have translation status info. labels Mar 11, 2022
sunetic
sunetic approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@sunetic sunetic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hfxsd
hfxsd approved these changes Mar 17, 2022
View reviewed changes
Copy link
Collaborator

@hfxsd hfxsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shichun-0415
shichun-0415 approved these changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 18, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 18, 2022
@qiancai qiancai added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 18, 2022
@qiancai
Copy link
Collaborator

qiancai commented Mar 21, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 21, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 7290716

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 21, 2022
@ti-chi-bot ti-chi-bot merged commit af20687 into pingcap:master Mar 21, 2022
@qiancai qiancai added the type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. label Mar 21, 2022
@sleepymole sleepymole deleted the base64-psw branch March 21, 2022 08:22
@qiancai qiancai removed the translation/doing This PR’s assignee is translating this PR. label Mar 22, 2022
@qiancai qiancai added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Mar 22, 2022
@ran-huang ran-huang mentioned this pull request Mar 24, 2022
Merged
16 tasks
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 1, 2022
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hfxsd hfxsd hfxsd approved these changes

@qiancai qiancai qiancai approved these changes

+2 more reviewers

@sunetic sunetic sunetic approved these changes

@shichun-0415 shichun-0415 shichun-0415 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@qiancai qiancai

Labels

area/tidb-lightning Indicates that the Issue or PR belongs to the area of TiDB Lightning. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v6.0 This PR/issue applies to TiDB v6.0.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@sleepymole @ti-chi-bot @qiancai @sunetic @hfxsd @shichun-0415 @TomShawn