Skip to content

Update docs for base64 encoding of password and kill auto analyze #7896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ti-chi-bot merged 5 commits into from
Apr 1, 2022
Merged

Update docs for base64 encoding of password and kill auto analyze #7896

ti-chi-bot merged 5 commits into from
Apr 1, 2022

Conversation

@qiancai
Copy link
Collaborator

@qiancai qiancai commented Mar 22, 2022 •
edited by ran-huang
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 22, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn March 22, 2022 01:33
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 22, 2022
@qiancai qiancai added the translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. label Mar 22, 2022
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Mar 22, 2022
@qiancai qiancai added missing-translation-status This PR does not have translation status info. v6.0 This PR/issue applies to TiDB v6.0. area/tidb-lightning Indicates that the Issue or PR belongs to the area of TiDB Lightning. and removed missing-translation-status This PR does not have translation status info. labels Mar 22, 2022
@qiancai qiancai requested review from shichun-0415 and sleepymole and removed request for TomShawn March 22, 2022 01:34
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 22, 2022
@qiancai qiancai changed the title Update docs for base64 encoding of password Update docs for base64 encoding of password and kill auto analyze Mar 22, 2022
sleepymole
sleepymole reviewed Mar 22, 2022
View reviewed changes
tidb-lightning/tidb-lightning-configuration.md Outdated
| --tidb-status *port* | TiDB status port (default = 10080) | `tidb.status-port` |
| --tidb-user *user* | User name to connect to TiDB | `tidb.user` |
| --tidb-password *password* | Password to connect to TiDB | `tidb.password` |
| --tidb-password *password* | Password to connect to TiDB. The password can be either plaintext or Base64 encoded. | `tidb.password` |
Copy link

@sleepymole sleepymole Mar 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

xuyifangreeneyes
xuyifangreeneyes reviewed Mar 30, 2022
View reviewed changes
shichun-0415
shichun-0415 reviewed Mar 30, 2022
View reviewed changes
@Oreoxmt Oreoxmt assigned Oreoxmt and unassigned Oreoxmt Mar 30, 2022
@qiancai @xuyifangreeneyes @shichun-0415
Apply suggestions from code review
ac536b1 
Co-authored-by: Yifan Xu <30385241+xuyifangreeneyes@users.noreply.github.com>
Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>
qiancai
qiancai commented Mar 31, 2022
View reviewed changes
shichun-0415
shichun-0415 approved these changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 1, 2022
@qiancai
Copy link
Collaborator Author

qiancai commented Apr 1, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 1, 2022

@qiancai: /merge in this pull request requires 2 approval(s).

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@qiancai
Copy link
Collaborator Author

qiancai commented Apr 1, 2022

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 1, 2022
@qiancai
Copy link
Collaborator Author

qiancai commented Apr 1, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 1, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: b4dc133

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 1, 2022
@ti-chi-bot ti-chi-bot merged commit ed764b3 into pingcap:master Apr 1, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 1, 2022
Merged
16 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 1, 2022

In response to a cherrypick label: new pull request created: #8032.

ti-chi-bot added a commit that referenced this pull request Apr 1, 2022
@ti-chi-bot
Update docs for base64 encoding of password and kill auto analyze (#7896
8b60ebd 
) (#8032)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@sleepymole sleepymole sleepymole left review comments

@xuyifangreeneyes xuyifangreeneyes xuyifangreeneyes approved these changes

@shichun-0415 shichun-0415 shichun-0415 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/tidb-lightning Indicates that the Issue or PR belongs to the area of TiDB Lightning. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v6.0 This PR/issue applies to TiDB v6.0.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@qiancai @ti-chi-bot @sleepymole @xuyifangreeneyes @shichun-0415 @Oreoxmt