Skip to content

fix typo in placement rules (#8813) #8814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TomShawn merged 1 commit into from
Apr 1, 2022
Merged

fix typo in placement rules (#8813) #8814

TomShawn merged 1 commit into from
Apr 1, 2022

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Apr 1, 2022

This is an automated cherry-pick of #8813

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Apr 1, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. require-LGT1 Indicates that the PR requires an LGTM. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-6.0 This PR is cherry-picked to release-6.0 from a source PR. v6.0 This PR/issue applies to TiDB v6.0. labels Apr 1, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 1, 2022
Merged
15 tasks
@ti-chi-bot ti-chi-bot requested a review from TomShawn April 1, 2022 07:53
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 1, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 1, 2022
@TomShawn
Copy link
Contributor

TomShawn commented Apr 1, 2022

/verify

@aytrack
Copy link
Contributor

aytrack commented Apr 1, 2022

english doc has same problems .

@TomShawn
Copy link
Contributor

TomShawn commented Apr 1, 2022

english doc has same problems .

The English doc is fixed in pingcap/docs#8011.

@TomShawn
Copy link
Contributor

TomShawn commented Apr 1, 2022

/verify

2 similar comments
@TomShawn
Copy link
Contributor

TomShawn commented Apr 1, 2022

/verify

@TomShawn
Copy link
Contributor

TomShawn commented Apr 1, 2022

/verify

@TomShawn
Copy link
Contributor

TomShawn commented Apr 1, 2022

/merge

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Apr 1, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 64aea80

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 1, 2022
@TomShawn TomShawn merged commit 54b0788 into pingcap:release-6.0 Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TomShawn TomShawn

Labels

area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-6.0 This PR is cherry-picked to release-6.0 from a source PR. v6.0 This PR/issue applies to TiDB v6.0.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ti-chi-bot @TomShawn @aytrack