Skip to content

Conversation

@xhebox
Copy link
Contributor

@xhebox xhebox commented Apr 1, 2022

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@xhebox xhebox requested review from TomShawn and aytrack April 1, 2022 06:37
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 1, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 1, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 1, 2022
@TomShawn TomShawn added translation/doing This PR's assignee is translating this PR. v6.0 This PR/issue applies to TiDB v6.0. needs-cherry-pick-release-6.0 labels Apr 1, 2022
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Apr 1, 2022
@TomShawn TomShawn added type/bugfix This PR fixes a bug. area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. labels Apr 1, 2022
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. require-LGT1 Indicates that the PR requires an LGTM. and removed translation/doing This PR's assignee is translating this PR. labels Apr 1, 2022
@TomShawn
Copy link
Contributor

TomShawn commented Apr 1, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: fbd245c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 1, 2022
@TomShawn
Copy link
Contributor

TomShawn commented Apr 1, 2022

/merge

@TomShawn TomShawn merged commit 6b92fac into master Apr 1, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 1, 2022
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8021.

@TomShawn TomShawn deleted the xhebox-patch-1 branch April 1, 2022 07:52
ti-chi-bot added a commit that referenced this pull request Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/bugfix This PR fixes a bug. v6.0 This PR/issue applies to TiDB v6.0.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants