Skip to content

en: add docs for backup and restore aws using BR#45

Merged
TomShawn merged 9 commits into
pingcap:masterfrom
ran-huang:backup-restore-aws-br
Mar 30, 2020
Merged

en: add docs for backup and restore aws using BR#45
TomShawn merged 9 commits into
pingcap:masterfrom
ran-huang:backup-restore-aws-br

Conversation

@ran-huang
Copy link
Copy Markdown
Contributor

@ran-huang ran-huang commented Mar 25, 2020

What is changed, added or deleted? (Required)

Add docs for backup to and restore from aws using BR

Which TiDB Operator version(s) do your changes apply to? (Required)

  • master (the latest development version, including v1.1 changes for now)
  • v1.0 (TiDB Operator 1.0 versions)

What is the related PR or file link(s)?

@ran-huang ran-huang added priority/P1 The issue has P1 priority. translation/from-zh This PR is translated from a PR in docs-tidb-operator/zh. and removed status/WIP labels Mar 27, 2020
@ran-huang ran-huang marked this pull request as ready for review March 27, 2020 04:23
@ran-huang
Copy link
Copy Markdown
Contributor Author

ran-huang commented Mar 27, 2020

@TomShawn This PR is very similar to #1. PTAL~ Thanks!

shuijing198799
shuijing198799 approved these changes Mar 27, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@shuijing198799 shuijing198799 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ran-huang ran-huang mentioned this pull request Mar 28, 2020
Merged
2 tasks
@ran-huang ran-huang mentioned this pull request Mar 30, 2020
Merged
2 tasks
TomShawn
TomShawn reviewed Mar 30, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address these comments and I'll review the other one.

Comment thread en/backup-to-aws-s3-using-br.md Outdated
Comment thread en/backup-to-aws-s3-using-br.md Outdated
Comment thread en/backup-to-aws-s3-using-br.md Outdated
Comment thread en/backup-to-aws-s3-using-br.md Outdated
Comment thread en/backup-to-aws-s3-using-br.md Outdated
Comment thread en/backup-to-aws-s3-using-br.md
kubectl apply -f backup-scheduler-aws-s3.yaml
```

The content of `backup-scheduler-aws-s3.yaml` is as follows:
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn Mar 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto, please check the sequence.

Comment thread en/backup-to-aws-s3-using-br.md Outdated
Comment thread en/backup-to-aws-s3-using-br.md
kubectl apply -f backup-scheduler-aws-s3.yaml
```

The content of `backup-scheduler-aws-s3.yaml` is as follows:
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn Mar 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto, please check the sequence.

Comment thread en/backup-to-aws-s3-using-br.md Outdated
Comment thread en/backup-to-aws-s3-using-br.md
kubectl apply -f backup-scheduler-aws-s3.yaml
```

The content of `backup-scheduler-aws-s3.yaml` is as follows:
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn Mar 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto, please check the sequence.

ran-huang and others added 2 commits March 30, 2020 16:54
@ran-huang @TomShawn
Apply suggestions from Tom in backup
970d4c8 
Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>
@ran-huang
address comments
0980cc9
@ran-huang
Copy link
Copy Markdown
Contributor Author

ran-huang commented Mar 30, 2020

@TomShawn Updated the two files according to your comments. PTAL again~

TomShawn
TomShawn reviewed Mar 30, 2020
View reviewed changes
Comment thread en/restore-from-aws-s3-using-br.md Outdated
Comment thread en/restore-from-aws-s3-using-br.md
Comment thread en/restore-from-aws-s3-using-br.md Outdated
Comment thread en/restore-from-aws-s3-using-br.md Outdated
Comment thread en/restore-from-aws-s3-using-br.md Outdated
Comment thread en/restore-from-aws-s3-using-br.md Outdated
Comment thread en/restore-from-aws-s3-using-br.md Outdated
Comment thread en/restore-from-aws-s3-using-br.md Outdated
Comment thread en/restore-from-aws-s3-using-br.md
Comment thread en/restore-from-aws-s3-using-br.md Outdated
ran-huang and others added 2 commits March 30, 2020 19:51
@ran-huang @TomShawn
Apply suggestions from code review
370b897 
Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>
@ran-huang
address comments
da4d0d7
@ran-huang
Copy link
Copy Markdown
Contributor Author

ran-huang commented Mar 30, 2020

@TomShawn Comments addressed. PTAL~

TomShawn
TomShawn reviewed Mar 30, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

Comment thread en/backup-to-aws-s3-using-br.md Outdated
Comment thread en/backup-to-aws-s3-using-br.md Outdated
Comment thread en/backup-to-aws-s3-using-br.md Outdated
Comment thread en/backup-to-aws-s3-using-br.md Outdated
Comment thread en/backup-to-aws-s3-using-br.md Outdated
Comment thread en/restore-from-aws-s3-using-br.md Outdated
Comment thread en/backup-to-aws-s3-using-br.md Outdated
Comment thread en/restore-from-aws-s3-using-br.md Outdated
@ran-huang @TomShawn
Apply suggestions from code review
2d53430 
Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>
TomShawn
TomShawn approved these changes Mar 30, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn TomShawn merged commit 0132db3 into pingcap:master Mar 30, 2020
sre-bot pushed a commit to sre-bot/docs-tidb-operator that referenced this pull request Mar 30, 2020
@ran-huang @TomShawn @sre-bot
en: add docs for backup and restore aws using BR (pingcap#45)
bdc3bf5 
* en: add docs for backup and restore aws br

* en: add backup and restore aws br doc

* Apply suggestions from Tom in backup

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

* address comments

* Apply suggestions from code review

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

* address comments

* Apply suggestions from code review

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@sre-bot sre-bot mentioned this pull request Mar 30, 2020
Merged
2 tasks
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Mar 30, 2020

cherry pick to release-1.1 in PR #101

TomShawn added a commit that referenced this pull request Mar 30, 2020
@sre-bot @ran-huang @TomShawn
en: add docs for backup and restore aws using BR (#45) (#101)
28e6c5c 
* en: add docs for backup and restore aws br

* en: add backup and restore aws br doc

* Apply suggestions from Tom in backup

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

* address comments

* Apply suggestions from code review

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

* address comments

* Apply suggestions from code review

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@ran-huang ran-huang deleted the backup-restore-aws-br branch April 7, 2020 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@shuijing198799 shuijing198799 shuijing198799 approved these changes

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

priority/P1 The issue has P1 priority. translation/from-zh This PR is translated from a PR in docs-tidb-operator/zh.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ran-huang @sre-bot @shuijing198799 @TomShawn