Skip to content

zh: add backup and restore aws br doc#5

Merged
ran-huang merged 9 commits into
pingcap:masterfrom
shuijing198799:yinliang/add-backup-aws-br-doc
Mar 19, 2020
Merged

zh: add backup and restore aws br doc#5
ran-huang merged 9 commits into
pingcap:masterfrom
shuijing198799:yinliang/add-backup-aws-br-doc

Conversation

@shuijing198799
Copy link
Copy Markdown
Contributor

What is changed, added or deleted? (Required)

Add backup and restore AWS TiDB Cluster with BR tool.

Which TiDB Operator version(s) do your changes apply to? (Required)

use the latest TiDB Operator and these changes will apply to release 1.1

  • master (the latest development version, including v1.1 changes for now)

What is changed, added or deleted? (Required)

Add backup and restore AWS TiDB Cluster with BR tool.

ons)

What is the related PR or file link(s)?

for preview:
https://github.com/shuijing198799/docs-tidb-operator/blob/master/zh/backup-to-aws-s3.md
https://github.com/shuijing198799/docs-tidb-operator/blob/master/zh/restore-from-aws-s3.md

  • This PR is translated from:
  • Other reference link(s):

@shuijing198799 shuijing198799 changed the title Yinliang/add backup aws br doc Backup: add backup and restore aws br doc Mar 17, 2020
@DanielZhangQD DanielZhangQD requested a review from ran-huang March 17, 2020 03:02
@ran-huang ran-huang added size/large Changes of a large size. translation/welcome Waits for a contributor to translate this PR to docs-tidb-operator/zh or docs-tidb-operator/en. labels Mar 17, 2020
@lilin90 lilin90 changed the title Backup: add backup and restore aws br doc backup: add backup and restore aws br doc Mar 17, 2020
@lilin90 lilin90 changed the title backup: add backup and restore aws br doc zh: add backup and restore aws br doc Mar 17, 2020
@DanielZhangQD DanielZhangQD self-requested a review March 17, 2020 03:12
Copy link
Copy Markdown
Contributor

@ran-huang ran-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shuijing198799 Please address comments in backup-to-aws-s3.md, and make changes to restore-from-aws-s3.md if applicable.
Thanks!

Comment thread zh/backup-to-aws-s3.md Outdated
Comment thread zh/backup-to-aws-s3.md Outdated
Comment thread zh/backup-to-aws-s3.md Outdated
Comment thread zh/backup-to-aws-s3.md Outdated
Comment thread zh/backup-to-aws-s3.md Outdated
Comment thread zh/backup-to-aws-s3.md Outdated
Comment thread zh/backup-to-aws-s3.md Outdated
Comment thread zh/backup-to-aws-s3.md Outdated
Comment thread zh/backup-to-aws-s3.md Outdated
Comment thread zh/backup-to-aws-s3.md Outdated
@ran-huang ran-huang self-assigned this Mar 17, 2020
@ran-huang ran-huang added translation/doing This PR’s assignee is translating this PR. priority/P1 The issue has P1 priority. and removed translation/welcome Waits for a contributor to translate this PR to docs-tidb-operator/zh or docs-tidb-operator/en. labels Mar 17, 2020
Comment thread zh/restore-from-aws-s3.md Outdated
Comment thread zh/restore-from-aws-s3.md Outdated
Comment thread zh/restore-from-aws-s3.md Outdated
Comment thread zh/restore-from-aws-s3.md Outdated
Comment thread zh/restore-from-aws-s3.md Outdated
Comment thread zh/restore-from-aws-s3.md Outdated
Comment thread zh/restore-from-aws-s3.md Outdated
Comment thread zh/restore-from-aws-s3.md Outdated
Comment thread zh/restore-from-aws-s3.md Outdated
Comment thread zh/backup-to-aws-s3.md Outdated
Comment thread zh/backup-to-aws-s3.md Outdated
Comment thread zh/backup-to-aws-s3.md Outdated
Comment thread zh/backup-to-aws-s3.md Outdated
Comment thread zh/backup-to-aws-s3.md Outdated
Comment thread zh/backup-to-aws-s3.md Outdated
Comment thread zh/backup-to-aws-s3.md Outdated
Comment thread zh/backup-to-aws-s3.md Outdated
Comment thread zh/backup-to-aws-s3.md Outdated
Comment thread zh/backup-to-aws-s3.md Outdated
@DanielZhangQD
Copy link
Copy Markdown
Contributor

Would it be better if we extract the common parts of the two docs into a separate one and then the backup and restore can refer to this doc without duplicating the info?

Comment thread zh/restore-from-aws-s3.md Outdated
@shuijing198799 shuijing198799 force-pushed the yinliang/add-backup-aws-br-doc branch from 192f81b to 42bcc24 Compare March 18, 2020 10:57
Comment thread zh/backup-to-aws-s3.md Outdated
Comment thread zh/restore-from-aws-s3.md Outdated
Comment thread zh/restore-from-aws-s3.md Outdated
Comment thread zh/backup-to-aws-s3.md Outdated
Comment thread zh/backup-to-aws-s3.md Outdated
Copy link
Copy Markdown
Contributor

@ran-huang ran-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

Comment thread zh/backup-to-aws-s3.md Outdated
Copy link
Copy Markdown
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ran-huang ran-huang merged commit 2da9e70 into pingcap:master Mar 19, 2020
DanielZhangQD pushed a commit that referenced this pull request Mar 26, 2020
@ran-huang ran-huang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Mar 27, 2020
Comment thread zh/backup-to-aws-s3.md
Comment thread zh/restore-from-aws-s3.md
Comment thread zh/restore-from-aws-s3.md

本文详细描述了如何将存储在 Amazon S3 存储的备份数据恢复到 AWS Kubernetes 环境中的 TiDB 集群,底层通过使用 [`BR`](https://pingcap.com/docs-cn/v3.1/reference/tools/br/br) 进行数据恢复。

本文使用的恢复方式基于 TiDB Operator 新版(v1.1 及以上)的 Custom Resource Definition (CRD) 实现。
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn Mar 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid using relative words such as new and old. For v1.0, v1.1 is new. For v1.6, v1.1 is old.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority/P1 The issue has P1 priority. size/large Changes of a large size. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants