Skip to content

en: update lightning deployment using S3 IAM#86

Merged
TomShawn merged 5 commits into
pingcap:masterfrom
ran-huang:lightning-deploy
Mar 31, 2020
Merged

en: update lightning deployment using S3 IAM#86
TomShawn merged 5 commits into
pingcap:masterfrom
ran-huang:lightning-deploy

Conversation

@ran-huang
Copy link
Copy Markdown
Contributor

What is changed, added or deleted? (Required)

Which TiDB Operator version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v1.1 (TiDB Operator 1.1 versions)
  • v1.0 (TiDB Operator 1.0 versions)

What is the related PR or file link(s)?

@ran-huang ran-huang added needs-cherry-pick-1.1 translation/from-zh This PR is translated from a PR in docs-tidb-operator/zh. priority/P2 The issue has P2 priority. labels Mar 30, 2020
@ran-huang ran-huang marked this pull request as ready for review March 30, 2020 12:43
Copy link
Copy Markdown
Contributor

@shuijing198799 shuijing198799 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

Comment thread en/restore-data-using-tidb-lightning.md Outdated
Comment thread en/restore-data-using-tidb-lightning.md Outdated
Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn
Copy link
Copy Markdown
Contributor

@ran-huang Have you updated this part?
image

@ran-huang
Copy link
Copy Markdown
Contributor Author

@ran-huang Have you updated this part?
image

Yes, it's been included when I created the restore-from-aws-s3-using-br.md file. image

@TomShawn TomShawn merged commit b2ea28f into pingcap:master Mar 31, 2020
@ran-huang ran-huang deleted the lightning-deploy branch March 31, 2020 07:58
sre-bot pushed a commit to sre-bot/docs-tidb-operator that referenced this pull request Mar 31, 2020
* update restore data using lightning

* Update backup-to-aws-s3-using-br.md

* minor update

* Apply suggestions from code review

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Mar 31, 2020

cherry pick to release-1.1 in PR #124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority/P2 The issue has P2 priority. translation/from-zh This PR is translated from a PR in docs-tidb-operator/zh.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants