Rehash of statistics page#16869
Conversation
|
Hi @terry1purcell. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
dveeden
left a comment
There was a problem hiding this comment.
A few places could use links to the SQL statements (mostly places related to loading and exporting statistics)
The "copyable" lines can all be removed iirc.
There are a few 'sqlgram' uses. Would be best to replace them with the new EBNF things. #4389
|
Adding @mjonss as reviewer for the parts that are related to partitioning. |
Co-authored-by: Grace Cai <qqzczy@126.com>
|
/test pull-verify |
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lilin90 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
First-time contributors' checklist
What is changed, added or deleted? (Required)
Improved readability of the statistics page. Including clarification of the different statistics.
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?