Skip to content

Rehash and update statistics and SQL docs#17827

Merged
ti-chi-bot[bot] merged 17 commits into
pingcap:masterfrom
lilin90:improve-statistics
Jul 24, 2024
Merged

Rehash and update statistics and SQL docs#17827
ti-chi-bot[bot] merged 17 commits into
pingcap:masterfrom
lilin90:improve-statistics

Conversation

@lilin90
Copy link
Copy Markdown
Member

@lilin90 lilin90 commented Jun 28, 2024

What is changed, added or deleted? (Required)

  • Rehash the basic statistics doc page to make it better organized
  • Update statistics related things to use EBNF etc.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@lilin90 lilin90 added translation/from-docs This PR is translated from a PR in pingcap/docs. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Jun 28, 2024
@lilin90 lilin90 self-assigned this Jun 28, 2024
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Jun 28, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 28, 2024
@lilin90 lilin90 changed the title Reorg and update statistics docs Rehash and update statistics docs Jul 2, 2024
@ti-chi-bot ti-chi-bot Bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 8, 2024
@lilin90 lilin90 added the type/enhancement The issue or PR belongs to an enhancement. label Jul 8, 2024
@ti-chi-bot ti-chi-bot Bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 11, 2024
@lilin90 lilin90 marked this pull request as ready for review July 11, 2024 09:42
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 11, 2024
@lilin90 lilin90 requested review from qiancai and winoros July 11, 2024 09:43
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 18, 2024
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Jul 18, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-18 09:45:00.91247965 +0000 UTC m=+519922.903421117: ☑️ agreed by qiancai.

Comment thread statistics.md
如果分区为空,或者某些分区上的列缺失,那么统计信息收集行为将受 [`tidb_skip_missing_partition_stats`](/system-variables.md#tidb_skip_missing_partition_stats-从-v730-版本开始引入) 变量的控制:

在执行 `ANALYZE` 普通列任务的时候,[`tidb_build_sampling_stats_concurrency`](/system-variables.md#tidb_build_sampling_stats_concurrency-从-v750-版本开始引入) 可以用于控制执行采样任务的并发数量,其默认值是 `2`。
- 当触发 GlobalStats 更新且 [`tidb_skip_missing_partition_stats`](/system-variables.md#tidb_skip_missing_partition_stats-从-v730-版本开始引入) 为 `OFF` 时:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GlobalStats 需要翻译回 全局统计信息

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

因为涉及多个文件里的多处,我最近另提一个 PR 来统一改。

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Jul 24, 2024

@winoros: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lilin90 lilin90 added the lgtm label Jul 24, 2024
@lilin90
Copy link
Copy Markdown
Member Author

lilin90 commented Jul 24, 2024

/approve

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Jul 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Jul 24, 2024
@ti-chi-bot ti-chi-bot Bot merged commit cbccda9 into pingcap:master Jul 24, 2024
@lilin90 lilin90 deleted the improve-statistics branch July 24, 2024 13:17
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Jul 24, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #18100.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Jul 24, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-8.2: #18101.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. translation/from-docs This PR is translated from a PR in pingcap/docs. type/enhancement The issue or PR belongs to an enhancement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants