Skip to content

Update statistics related things to use EBNF etc#17464

Merged
ti-chi-bot[bot] merged 13 commits into
pingcap:masterfrom
dveeden:sqlgram__ebnf
May 23, 2024
Merged

Update statistics related things to use EBNF etc#17464
ti-chi-bot[bot] merged 13 commits into
pingcap:masterfrom
dveeden:sqlgram__ebnf

Conversation

@dveeden
Copy link
Copy Markdown
Contributor

@dveeden dveeden commented May 10, 2024 •
edited by qiancai
Loading

What is changed, added or deleted? (Required)

Closes #17463

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@dveeden dveeden requested review from Oreoxmt, kennytm and qiancai May 10, 2024 09:52
@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 10, 2024
@dveeden
Copy link
Copy Markdown
Contributor Author

dveeden commented May 10, 2024

@terry1purcell could you review this?

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented May 10, 2024

@kennytm: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@terry1purcell
Copy link
Copy Markdown
Contributor

terry1purcell commented May 10, 2024

@terry1purcell could you review this?

@dveeden - Looks good to me (I didn't use the acronym because I am not an authorized reviewer).

@qiancai qiancai requested a review from winoros May 15, 2024 07:53
@qiancai qiancai self-assigned this May 15, 2024
@qiancai qiancai added needs-cherry-pick-release-8.0 type/enhancement The issue or PR belongs to an enhancement. translation/doing This PR's assignee is translating this PR. area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. labels May 15, 2024
@ti-chi-bot ti-chi-bot Bot removed the missing-translation-status This PR does not have translation status info. label May 15, 2024
@qiancai qiancai removed the request for review from Liuxiaozhen12 May 15, 2024 08:02
@qiancai qiancai added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label May 15, 2024
qiancai
qiancai reviewed May 16, 2024
View reviewed changes
Comment thread sql-statements/sql-statement-show-column-stats-usage.md Outdated
Comment thread sql-statements/sql-statement-show-stats-buckets.md Outdated
Comment thread sql-statements/sql-statement-show-stats-healthy.md Outdated
Comment thread sql-statements/sql-statement-show-stats-buckets.md Outdated
Comment thread sql-statements/sql-statement-show-stats-histograms.md Outdated
Comment thread sql-statements/sql-statement-show-stats-locked.md Outdated
Comment thread sql-statements/sql-statement-show-stats-locked.md Outdated
Comment thread sql-statements/sql-statement-show-stats-topn.md Outdated
Comment thread statistics.md
Comment thread statistics.md
@dveeden @qiancai
Update sql-statements/sql-statement-show-column-stats-usage.md
0a811d3 
Co-authored-by: Grace Cai <qqzczy@126.com>
@ti-chi-bot ti-chi-bot Bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 16, 2024
@dveeden
Copy link
Copy Markdown
Contributor Author

dveeden commented May 16, 2024

There is still one comment in https://github.com/pingcap/docs/pull/17464/files#r1602703834, which is not shown by default because large diffs in statistics.md are not rendered by default.

Yes, I'll have a look at that.

dveeden and others added 2 commits May 16, 2024 11:52
@dveeden
Copy link
Copy Markdown
Contributor Author

dveeden commented May 22, 2024

@qiancai PTAL

@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label May 22, 2024
@hfxsd hfxsd self-requested a review May 22, 2024 09:34
hfxsd
hfxsd approved these changes May 22, 2024
View reviewed changes
Comment thread sql-statements/sql-statement-show-column-stats-usage.md Outdated
Comment thread sql-statements/sql-statement-show-stats-buckets.md Outdated
Comment thread sql-statements/sql-statement-show-stats-buckets.md Outdated
Comment thread sql-statements/sql-statement-show-stats-healthy.md Outdated
Comment thread sql-statements/sql-statement-show-stats-histograms.md Outdated
Comment thread sql-statements/sql-statement-show-stats-locked.md Outdated
Comment thread sql-statements/sql-statement-show-stats-topn.md Outdated
@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 22, 2024
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented May 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-22 09:06:46.375322532 +0000 UTC m=+2248960.132458105: ☑️ agreed by qiancai.
  • 2024-05-22 12:03:39.237333793 +0000 UTC m=+2259572.994469366: ☑️ agreed by hfxsd.

dveeden and others added 2 commits May 22, 2024 15:48
@dveeden @hfxsd
Update sql-statements/sql-statement-show-stats-topn.md
ddf7e07 
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
@dveeden @hfxsd
Apply suggestions from code review
292e1bc 
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
@Oreoxmt Oreoxmt removed their request for review May 23, 2024 06:44
@qiancai
Copy link
Copy Markdown
Collaborator

qiancai commented May 23, 2024

/approve

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented May 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label May 23, 2024
@ti-chi-bot ti-chi-bot Bot merged commit acdd0c1 into pingcap:master May 23, 2024
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented May 23, 2024

In response to a cherrypick label: new pull request created to branch release-8.1: #17606.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request May 23, 2024
@dveeden @ti-chi-bot
This is an automated cherry-pick of pingcap#17464
6645495 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request May 23, 2024
Merged
16 tasks
ti-chi-bot Bot pushed a commit that referenced this pull request May 23, 2024
@ti-chi-bot
Update statistics related things to use EBNF etc (#17464) (#17606)
3a73f31
@lilin90 lilin90 self-assigned this Jun 3, 2024
@lilin90 lilin90 mentioned this pull request Jun 28, 2024
Merged
17 tasks
@qiancai qiancai added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Jul 16, 2024
This was referenced Jul 24, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kennytm kennytm kennytm approved these changes

@hfxsd hfxsd hfxsd approved these changes

@qiancai qiancai qiancai approved these changes

@bb7133 bb7133 Awaiting requested review from bb7133

@YangKeao YangKeao Awaiting requested review from YangKeao

@winoros winoros Awaiting requested review from winoros

Assignees

@lilin90 lilin90

@qiancai qiancai

Labels

approved area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. lgtm needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

statistics.md

7 participants

@dveeden @terry1purcell @qiancai @ti-chi-bot @kennytm @hfxsd @lilin90