*: make the expressions of GlobalStats consistent#18807
Merged
ti-chi-bot[bot] merged 12 commits intoNov 26, 2024
Conversation
lilin90
added
needs-cherry-pick-release-8.1
ti-chi-bot
Bot
added
the
size/XS
lilin90
added
do-not-merge/work-in-progress
ti-chi-bot
Bot
added
the
size/XS
lilin90
removed
the
needs-cherry-pick-release-8.1
ti-chi-bot
Bot
added
size/M
[LGTM Timeline notifier]Timeline:
|
qiancai
reviewed
Nov 15, 2024
qiancai
reviewed
Nov 15, 2024
qiancai
reviewed
Nov 15, 2024
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
lilin90
changed the title
winoros
approved these changes
Nov 21, 2024
|
@winoros: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Member
Author
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lilin90 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
This PR makes the expressions of GlobalStats consistent and easier to understand based on this comment pingcap/docs-cn#17827 (comment) and communication with winoros. It's a follow-up to pingcap/docs-cn#17827.
Specifically, this PR changes
GlobalStatstoglobal statistics of partitioned tables, or justglobal statisticswhen the context is clear to avoid redundancy.Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?