Skip to content

reference/configuration: update note for stmt-count-limit#1984

Merged
sre-bot merged 2 commits into
pingcap:masterfrom
TomShawn:stmt_limit
Mar 10, 2020
Merged

reference/configuration: update note for stmt-count-limit#1984
sre-bot merged 2 commits into
pingcap:masterfrom
TomShawn:stmt_limit

Conversation

@TomShawn
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn commented Mar 10, 2020

What is changed, added or deleted? (Required)

stmt-count-limit does not work for all types of transactions. Update its note.

[事务重试](/reference/transactions/transaction-optimistic.md#事务的重试) is still being translated into English in #1695, so I remove this link in this PR and will add it back when #1695 is merged.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version, including v4.0 changes for now)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

@TomShawn TomShawn added size/small Changes of a small size. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. requires-followup This PR requires a follow-up task after being merged. labels Mar 10, 2020
- The maximum number of statements allowed in a single TiDB transaction.
- Default value: `5000`
- If a transaction does not roll back or commit after the number of statements exceeds `stmt-count-limit`, TiDB returns the `statement count 5001 exceeds the transaction limitation, autocommit = false` error.
- If a transaction does not roll back or commit after the number of statements exceeds `stmt-count-limit`, TiDB returns the `statement count 5001 exceeds the transaction limitation, autocommit = false` error. This configuration takes effect **only** in the retriable optimistic transaction. If you use the pessimistic transaction or have disabled the transaction retry, the number of statements in a transaction is not limited by this configuration.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add the link of the transaction retry?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The transaction retry part is to be translated in #1695, so I remove the link here. When #1695 is merged, I'll add this link here.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got

Copy link
Copy Markdown
Contributor

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@anotherrachel anotherrachel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn TomShawn added the status/can-merge Indicates a PR has been approved by a committer. label Mar 10, 2020
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Mar 10, 2020

/run-all-tests

@sre-bot sre-bot merged commit e58f315 into pingcap:master Mar 10, 2020
@TomShawn TomShawn deleted the stmt_limit branch March 10, 2020 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

requires-followup This PR requires a follow-up task after being merged. size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants