Translate tidb computing#3057
Merged
Merged
Conversation
|
|
github-actions
Bot
added
translation/welcome
Contributor
Author
|
@SunRunAway @yikeke PTAL, thanks! |
TomShawn
added
needs-cherry-pick-4.0
translation/from-docs-cn
Contributor
|
@SunRunAway, @TomShawn, PTAL. |
2 similar comments
Contributor
|
@SunRunAway, @TomShawn, PTAL. |
Contributor
|
@SunRunAway, @TomShawn, PTAL. |
TomShawn
reviewed
Jul 6, 2020
Contributor
TomShawn
left a comment
TomShawn
left a comment
There was a problem hiding this comment.
Good translation! I'll review the rest part soon.
TomShawn
added
status/require-change
TomShawn
reviewed
Jul 7, 2020
TomShawn
reviewed
Jul 8, 2020
TomShawn
reviewed
Jul 8, 2020
Contributor
TomShawn
left a comment
TomShawn
left a comment
There was a problem hiding this comment.
The second round of review
Contributor
|
@baurine, please update your pull request. |
Contributor
|
@TomShawn, @SunRunAway, PTAL. |
Contributor
|
LGTM |
Contributor
|
@TomShawn, @SunRunAway, PTAL. |
Contributor
|
@baurine, please update your pull request. |
Contributor
Author
|
Err, seems I have no permission to push code, what should I continue to do for this PR? |
Contributor
|
@TomShawn, @SunRunAway, PTAL. |
TomShawn
reviewed
Jul 17, 2020
Contributor
|
@TomShawn, @SunRunAway, PTAL. |
Contributor
|
@baurine, please update your pull request. |
SunRunAway
reviewed
Jul 20, 2020
Co-authored-by: Feng Liyuan <darktemplar.f@gmail.com>
Contributor
|
@SunRunAway,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack). |
ti-srebot
pushed a commit
to ti-srebot/docs
that referenced
this pull request
Jul 20, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
5 tasks
Contributor
|
cherry pick to release-4.0 in PR #3341 |
TomShawn
added a commit
that referenced
this pull request
Jul 20, 2020
* cherry pick #3057 to release-4.0 Signed-off-by: ti-srebot <ti-srebot@pingcap.com> * Apply suggestions from code review Co-authored-by: Sparkle <1284531+baurine@users.noreply.github.com> Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
Translate the TiDB Computation chapter from Chinese to English.
This PR should be merged after #3094 for the TOC to be updated.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?