Update TiDB architecture by uglyengineer · Pull Request #3094 · pingcap/docs

uglyengineer · 2020-06-30T19:11:33Z

What is changed, added or deleted? (Required)

Update content for architecture.md

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

This PR is translated from: architecture: add tidb-architecture, tidb-computing, tidb-storage docs-cn#3222
Other reference link(s):

CLAassistant · 2020-06-30T19:11:39Z

All committers have signed the CLA.

uglyengineer · 2020-06-30T19:15:13Z

@SunRunAway @TomShawn PTAL, thanks!

lilin90

Just did a quick review of format.

Co-authored-by: Lilian Lee <lilin@pingcap.com>

ti-srebot · 2020-07-04T06:00:37Z

@lilin90, @SunRunAway, PTAL.

ti-srebot · 2020-07-05T17:42:36Z

@uglyengineer, please update your pull request.

ti-srebot · 2020-07-06T06:00:37Z

@lilin90, @SunRunAway, PTAL.

lilin90 · 2020-07-07T12:23:26Z

@uglyengineer Please fix the image link which causes lint failure.

ti-srebot · 2020-07-09T12:25:05Z

@lilin90, @SunRunAway, PTAL.

ti-srebot · 2020-07-09T12:25:11Z

@uglyengineer, please update your pull request.

ti-srebot · 2020-07-13T10:17:44Z

@uglyengineer, please update your pull request.

ti-srebot · 2020-07-13T10:19:45Z

@lilin90, @SunRunAway, PTAL.

ti-srebot · 2020-07-15T10:19:15Z

@lilin90, @SunRunAway, PTAL.

Co-authored-by: Lilian Lee <lilin@pingcap.com>

lilin90

LGTM

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot · 2020-07-16T09:27:24Z

cherry pick to release-4.0 in PR #3299

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ran-huang · 2020-07-16T10:21:17Z

 + Reference
-  + [Architecture](/architecture.md)
+  + Cluster Architecture
+    + [Overview](/architecture.md)


@lilin90 @uglyengineer The corresponding Chinese file is tidb-architecture.md. Different file names might bring inconvenience to later maintenance. Is this by design?

Suggest renaming it to tidb-architecture.md to align the Chinese doc. @lilin90 @uglyengineer

Can you do it in your PR #3300? @ran-huang

Sure. Updated.

Update architecture.md

6b7c291

yikeke requested review from SunRunAway and lilin90 July 1, 2020 02:27

yikeke added needs-cherry-pick-4.0 status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Jul 1, 2020

Merge branch 'master' into update-arch

a1ebe27

lilin90 reviewed Jul 2, 2020

View reviewed changes

Comment thread architecture.md Outdated

Comment thread architecture.md Outdated

Comment thread architecture.md

lilin90 added size/medium Changes of a medium size. status/require-change Needs the author to address comments. labels Jul 2, 2020

uglyengineer and others added 3 commits July 4, 2020 01:40

Update architecture.md

f6d2365

Co-authored-by: Lilian Lee <lilin@pingcap.com>

Update architecture.md

ac493c8

Co-authored-by: Lilian Lee <lilin@pingcap.com>

Update architecture.md

34d479e

Co-authored-by: Lilian Lee <lilin@pingcap.com>

baurine mentioned this pull request Jul 6, 2020

Translate tidb computing #3057

Merged

5 tasks

Merge branch 'master' into update-arch

32431c7

uglyengineer added 2 commits July 11, 2020 18:07

Update architecture.md

0295b10

Update tidb-architecture.png

bd97e62

uglyengineer requested a review from lilin90 July 11, 2020 10:17

Update TOC.md

697f01f

lilin90 changed the title ~~Update architecture.md~~ Update TiDB architecture Jul 16, 2020

lilin90 reviewed Jul 16, 2020

View reviewed changes

lilin90 and others added 12 commits July 16, 2020 17:06

Fix an anchor link to resolve lint failure

f9eada5

Merge branch 'master' into update-arch

ff30ee2

Update architecture.md

486e170

Co-authored-by: Lilian Lee <lilin@pingcap.com>

Update architecture.md

e1cee63

Co-authored-by: Lilian Lee <lilin@pingcap.com>

Update architecture.md

a122859

Co-authored-by: Lilian Lee <lilin@pingcap.com>

Update architecture.md

1fc690e

Co-authored-by: Lilian Lee <lilin@pingcap.com>

Update architecture.md

8167e7c

Co-authored-by: Lilian Lee <lilin@pingcap.com>

Update architecture.md

695be2f

Co-authored-by: Lilian Lee <lilin@pingcap.com>

Update architecture.md

54b279b

Co-authored-by: Lilian Lee <lilin@pingcap.com>

Update architecture.md

d20f10e

Co-authored-by: Lilian Lee <lilin@pingcap.com>

Update architecture.md

beb9d4b

Co-authored-by: Lilian Lee <lilin@pingcap.com>

Update architecture.md

4839fb2

Co-authored-by: Lilian Lee <lilin@pingcap.com>

uglyengineer requested a review from lilin90 July 16, 2020 09:11

Apply suggestions from code review

8384dd2

lilin90 reviewed Jul 16, 2020

View reviewed changes

Comment thread architecture.md Outdated

lilin90 added 2 commits July 16, 2020 17:16

Update architecture.md

a3c87bd

Update wording

3318446

lilin90 approved these changes Jul 16, 2020

View reviewed changes

ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 16, 2020

lilin90 merged commit 22425b6 into pingcap:master Jul 16, 2020

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 16, 2020

cherry pick pingcap#3094 to release-4.0

4814882

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot mentioned this pull request Jul 16, 2020

Update TiDB architecture (#3094) #3299

Merged

5 tasks

ti-srebot added a commit that referenced this pull request Jul 16, 2020

Update TiDB architecture (#3094) (#3299)

04ffe5a

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ran-huang reviewed Jul 16, 2020

View reviewed changes

ran-huang mentioned this pull request Jul 16, 2020

add what's next links in quick start #3300

Merged

5 tasks

This was referenced Jul 16, 2020

add what's next links in quick start (#3300) #3304

Merged

Translate tidb computing (#3057) #3341

Merged

Conversation

uglyengineer commented Jun 30, 2020 • edited by lilin90 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Uh oh!

CLAassistant commented Jun 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

uglyengineer commented Jun 30, 2020

Uh oh!

lilin90 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ti-srebot commented Jul 4, 2020

Uh oh!

ti-srebot commented Jul 5, 2020

Uh oh!

ti-srebot commented Jul 6, 2020

Uh oh!

lilin90 commented Jul 7, 2020

Uh oh!

ti-srebot commented Jul 9, 2020

Uh oh!

ti-srebot commented Jul 9, 2020

Uh oh!

ti-srebot commented Jul 13, 2020

Uh oh!

ti-srebot commented Jul 13, 2020

Uh oh!

ti-srebot commented Jul 15, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lilin90 left a comment

Choose a reason for hiding this comment

Uh oh!

ti-srebot commented Jul 16, 2020

Uh oh!

ran-huang Jul 16, 2020

Choose a reason for hiding this comment

Uh oh!

yikeke Jul 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ran-huang Jul 16, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

uglyengineer commented Jun 30, 2020 •

edited by lilin90

Loading

CLAassistant commented Jun 30, 2020 •

edited

Loading

yikeke Jul 16, 2020 •

edited

Loading