system_tables: add column description for several tables#3322
Merged
Conversation
ran-huang
commented
Jul 17, 2020
ran-huang
commented
Jul 17, 2020
| * `CREATE_TIME`: The time at which the table is created. | ||
| * `UPDATE_TIME`: The time at which the table is updated. | ||
| * `CHECK_TIME`: The time at which the table is checked. | ||
| * `TABLE_COLLATION`: The collation of strings in the table. |
Contributor
Author
There was a problem hiding this comment.
Confirmed with the author on the translation of TABLE_COLLATION
TomShawn
reviewed
Jul 20, 2020
ran-huang
commented
Jul 21, 2020
ran-huang
commented
Jul 21, 2020
ran-huang
commented
Jul 21, 2020
ran-huang
commented
Jul 21, 2020
Contributor
Signed-off-by: Ran <huangran@pingcap.com>
Signed-off-by: Ran <huangran@pingcap.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Signed-off-by: Ran <huangran@pingcap.com>
Contributor
Author
|
@TomShawn PTAL again. Thanks 🙏 |
ti-srebot
pushed a commit
to ti-srebot/docs
that referenced
this pull request
Jul 21, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
5 tasks
Contributor
|
cherry pick to release-4.0 in PR #3358 |
ran-huang
added a commit
that referenced
this pull request
Jul 21, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Co-authored-by: Ran <huangran@pingcap.com>
5 tasks
yikeke
reviewed
Jul 31, 2020
Comment on lines
+42
to
+45
| +----------------+--------------------+ | ||
| | COLLATION_NAME | CHARACTER_SET_NAME | | ||
| | utf8mb4_bin | utf8mb4 | | ||
| +----------------+--------------------+ |
Contributor
There was a problem hiding this comment.
lines 42 to 45 are duplicate with lines 34 to 38. Removed duplicates in 5202185. (also for the Chinese version)
9 tasks
This was referenced Aug 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
Add column description for several information_schema tables:
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?