Skip to content

Fix some issues in information schema docs#3470

Merged
yikeke merged 8 commits into
pingcap:masterfrom
yikeke:fix-info-schema
Aug 3, 2020
Merged

Fix some issues in information schema docs#3470
yikeke merged 8 commits into
pingcap:masterfrom
yikeke:fix-info-schema

Conversation

@yikeke
Copy link
Copy Markdown
Contributor

@yikeke yikeke commented Jul 29, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

  1. Fixes some issues from system-databases: Refactor/Improve clarity #3178 and system_tables: add column description for several tables #3322;
  2. Align update document for system-table-information-schema.md docs-cn#3470

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@yikeke yikeke mentioned this pull request Jul 29, 2020
Merged
5 tasks
yikeke
yikeke commented Jul 29, 2020
View reviewed changes
Comment thread information-schema/information-schema-processlist.md Outdated
yikeke
yikeke commented Jul 29, 2020
View reviewed changes
Comment thread information-schema/information-schema-processlist.md Outdated
@yikeke yikeke added needs-cherry-pick-4.0 translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. labels Jul 29, 2020
@yikeke yikeke mentioned this pull request Jul 29, 2020
Merged
5 tasks
@ghost
Copy link
Copy Markdown

ghost commented Jul 29, 2020

LGTM

@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 29, 2020

@nullnotnil,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

@yikeke yikeke marked this pull request as ready for review July 30, 2020 12:46
@yikeke yikeke requested a review from a user July 30, 2020 12:58
@yikeke yikeke added the status/PTAL This PR is ready for reviewing. label Jul 30, 2020
@yikeke yikeke requested a review from lilin90 July 30, 2020 12:59
@ghost
Copy link
Copy Markdown

ghost commented Jul 30, 2020

LGTM

@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Jul 30, 2020

@nullnotnil,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

@yikeke
Copy link
Copy Markdown
Contributor Author

yikeke commented Jul 31, 2020

PTAL @lilin90

@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Aug 2, 2020

@lilin90, @nullnotnil, PTAL.

@ghost
Copy link
Copy Markdown

ghost commented Aug 2, 2020

LGTM, I think we can merge.

@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Aug 2, 2020

@nullnotnil,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

@yikeke yikeke added the require-LGT1 Indicates that the PR requires an LGTM. label Aug 3, 2020
@yikeke
Copy link
Copy Markdown
Contributor Author

yikeke commented Aug 3, 2020

/merge

@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Aug 3, 2020

@yikeke Oops! This PR requires at least 1 LGTMs to merge. The current number of LGTM is 0.

@yikeke yikeke merged commit f19b6c0 into pingcap:master Aug 3, 2020
@yikeke yikeke deleted the fix-info-schema branch August 3, 2020 02:46
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Aug 3, 2020
@yikeke @ti-srebot
cherry pick pingcap#3470 to release-4.0
ec79bcd 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 3, 2020
Merged
9 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Aug 3, 2020

cherry pick to release-4.0 in PR #3503

yikeke added a commit that referenced this pull request Aug 3, 2020
@ti-srebot @yikeke
cherry pick #3470 to release-4.0 (#3503)
99fb642 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
@ti-srebot ti-srebot mentioned this pull request Aug 5, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lilin90 lilin90 Awaiting requested review from lilin90

1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

require-LGT1 Indicates that the PR requires an LGTM. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yikeke @ti-srebot