Skip to content

tools: add shard table's check by table-rules for diff#3490

Merged
yikeke merged 14 commits into
pingcap:masterfrom
Joyinqin:table-rules
Aug 4, 2020
Merged

tools: add shard table's check by table-rules for diff#3490
yikeke merged 14 commits into
pingcap:masterfrom
Joyinqin:table-rules

Conversation

@Joyinqin
Copy link
Copy Markdown
Contributor

@Joyinqin Joyinqin commented Jul 30, 2020

What is changed, added or deleted? (Required)

Add shard table's check by table-rules for diff

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@Joyinqin
Copy link
Copy Markdown
Contributor Author

/label needs-cherry-pick-2.1, needs-cherry-pick-3.0, needs-cherry-pick-3.1, needs-cherry-pick-4.0, size/medium, translation/from-docs-cn

@ti-srebot ti-srebot added needs-cherry-pick-2.1 size/medium Changes of a medium size. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Jul 30, 2020
@Joyinqin
Copy link
Copy Markdown
Contributor Author

/cc yikeke

@ti-srebot ti-srebot requested a review from yikeke July 30, 2020 13:47
@Joyinqin
Copy link
Copy Markdown
Contributor Author

/cc WangXiangUSTC

@ti-srebot ti-srebot requested a review from WangXiangUSTC July 30, 2020 13:48
Copy link
Copy Markdown
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 31, 2020
@yikeke
Copy link
Copy Markdown
Contributor

yikeke commented Jul 31, 2020

You forgot to delete media/shard-table-sync.png.

Each time you have aligned a PR, make sure that you double-check whether the PR changes are consistent with the original version. @Joyinqin

Comment thread sync-diff-inspector/shard-diff.md Outdated
@yikeke yikeke requested a review from ireneontheway July 31, 2020 09:21
Comment thread sync-diff-inspector/shard-diff.md Outdated
Comment thread sync-diff-inspector/shard-diff.md Outdated
Comment thread sync-diff-inspector/shard-diff.md
Comment thread sync-diff-inspector/shard-diff.md
Comment thread sync-diff-inspector/shard-diff.md
Comment thread sync-diff-inspector/shard-diff.md Outdated
Comment thread sync-diff-inspector/sync-diff-inspector-overview.md Outdated
@pingcap pingcap deleted a comment from yikeke Aug 3, 2020
Co-authored-by: ireneontheway <48651140+ireneontheway@users.noreply.github.com>
Comment thread sync-diff-inspector/shard-diff.md Outdated
Comment thread sync-diff-inspector/shard-diff.md Outdated
Joyinqin and others added 2 commits August 3, 2020 21:11
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: ireneontheway <48651140+ireneontheway@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

Comment thread sync-diff-inspector/shard-diff.md Outdated
@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Aug 4, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Aug 4, 2020
@yikeke
Copy link
Copy Markdown
Contributor

yikeke commented Aug 4, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 4, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor

/run-all-tests

@yikeke yikeke merged commit 2a7276b into pingcap:master Aug 4, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Aug 4, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Copy Markdown
Contributor

cherry pick to release-2.1 in PR #3533

@Joyinqin Joyinqin deleted the table-rules branch August 4, 2020 04:00
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Aug 4, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Copy Markdown
Contributor

cherry pick to release-3.0 in PR #3534

yikeke pushed a commit that referenced this pull request Aug 4, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: JoyinQ <56883733+Joyinqin@users.noreply.github.com>
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Aug 4, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Copy Markdown
Contributor

cherry pick to release-3.1 in PR #3535

yikeke pushed a commit that referenced this pull request Aug 4, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: JoyinQ <56883733+Joyinqin@users.noreply.github.com>
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Aug 4, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Copy Markdown
Contributor

cherry pick to release-4.0 in PR #3536

ti-srebot added a commit that referenced this pull request Aug 4, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
ti-srebot added a commit that referenced this pull request Aug 4, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/medium Changes of a medium size. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants