Skip to content

ticdc: update tiup deployment prompt and filter rule link#3651

Merged
TomShawn merged 11 commits into
pingcap:masterfrom
Joyinqin:ticdc
Aug 17, 2020
Merged

ticdc: update tiup deployment prompt and filter rule link#3651
TomShawn merged 11 commits into
pingcap:masterfrom
Joyinqin:ticdc

Conversation

@Joyinqin
Copy link
Copy Markdown
Contributor

@Joyinqin Joyinqin commented Aug 13, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

  • add TiUP deployment prompt in TiCDC docs.
  • update the doc link of filter rule.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@Joyinqin Joyinqin changed the title ticdc: add tiup deployment prompt ticdc: update tiup deployment prompt and filter rule link Aug 13, 2020
@Joyinqin
Copy link
Copy Markdown
Contributor Author

Joyinqin commented Aug 13, 2020

/label translation/from-docs-cn, needs-cherry-pick-4.0, size/small

@ti-srebot ti-srebot added needs-cherry-pick-4.0 size/small Changes of a small size. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Aug 13, 2020
@Joyinqin
Copy link
Copy Markdown
Contributor Author

Joyinqin commented Aug 13, 2020

/cc yikeke, TomShawn

@ti-srebot ti-srebot requested review from TomShawn and yikeke August 13, 2020 05:40
@Joyinqin
Copy link
Copy Markdown
Contributor Author

Joyinqin commented Aug 13, 2020

/cc yikeke, TomShawn, lichunzhu, leoppro

@Joyinqin
Copy link
Copy Markdown
Contributor Author

Joyinqin commented Aug 13, 2020

/cc yikeke, TomShawn, lichunzhu, leoppro

@Joyinqin
Copy link
Copy Markdown
Contributor Author

Joyinqin commented Aug 13, 2020

/label status/PTAL

@ti-srebot ti-srebot added the status/PTAL This PR is ready for reviewing. label Aug 13, 2020
TomShawn
TomShawn reviewed Aug 13, 2020
View reviewed changes
Comment thread ticdc/manage-ticdc.md Outdated
Comment thread ticdc/ticdc-overview.md Outdated
Comment thread ticdc/ticdc-overview.md Outdated
Comment thread ticdc/ticdc-overview.md Outdated
@TomShawn TomShawn added status/require-change Needs the author to address comments. and removed status/PTAL This PR is ready for reviewing. labels Aug 13, 2020
@Joyinqin @TomShawn
Apply suggestions from code review
f4150ba 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@yikeke yikeke removed their request for review August 14, 2020 05:57
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Aug 15, 2020

@TomShawn, @lichunzhu, @leoppro, PTAL.

@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Aug 16, 2020

@Joyinqin, please update your pull request.

@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Aug 17, 2020

LGTM
@leoppro PTAL

zier-one
zier-one approved these changes Aug 17, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@zier-one zier-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Aug 17, 2020

@leoppro,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 17, 2020
@TomShawn TomShawn added require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. labels Aug 17, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Aug 17, 2020

/run-all-tests

@TomShawn TomShawn merged commit bb8a897 into pingcap:master Aug 17, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Aug 17, 2020
@Joyinqin @ti-srebot
cherry pick pingcap#3651 to release-4.0
4d2ced4 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 17, 2020
Merged
9 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Aug 17, 2020

cherry pick to release-4.0 in PR #3678

ti-srebot added a commit that referenced this pull request Aug 17, 2020
@ti-srebot
ticdc: update tiup deployment prompt and filter rule link (#3651) (#3678
c341039 
)

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lichunzhu lichunzhu Awaiting requested review from lichunzhu

2 more reviewers

@zier-one zier-one zier-one approved these changes

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

require-LGT1 Indicates that the PR requires an LGTM. size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/require-change Needs the author to address comments. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Joyinqin @ti-srebot @TomShawn @zier-one