Add docs for dynamic privileges by morgo · Pull Request #5077 · pingcap/docs

morgo · 2021-03-22T19:11:23Z

What is changed, added or deleted? (Required)

This feature documents pingcap/tidb#22778 which has not yet merged. It only applies to master, and fixes a couple of other small bugs (around password -> authentication_string).

The list of "Privileges required for TiDB operations" is changed to an example, because the list does not account for dynamic privileges so it gets confusing.

The PR includes comments for where the version after 5.0 will need to be inserted. Thus, the PR should be labeled as requiring followup after merging as well.

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

This PR is translated from:
Other reference link(s): *: add support for dynamic privileges tidb#22778

Do your changes match any of the following descriptions?

Delete files
Change aliases
Need modification after applied to another branch
Might cause conflicts after applied to another branch

yikeke · 2021-03-24T09:10:31Z

/label for-future-release

ti-chi-bot · 2021-03-24T09:10:32Z

@yikeke: The label(s) for-future-release cannot be applied. These labels are supported: DNM until Ansible tag is ready, Hacktoberfest, contribution, first-time-contributor, follow-up, good-first-issue, hacktoberfest-accepted, help-wanted, needs-cherry-pick-2.1, needs-cherry-pick-3.0, needs-cherry-pick-3.1, needs-cherry-pick-4.0, needs-cherry-pick-5.0, needs-cherry-pick-master, question, require-LGT1, require-LGT2, require-LGT3, special-week, v4.0, v5.0, v6.0, version-specific-changes-required, website.

Details

In response to this:

/label for-future-release

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2021-03-24T09:11:48Z

@yikeke: The label(s) for-future-release cannot be applied. These labels are supported: DNM until Ansible tag is ready, Hacktoberfest, contribution, first-time-contributor, follow-up, good-first-issue, hacktoberfest-accepted, help-wanted, needs-cherry-pick-2.1, needs-cherry-pick-3.0, needs-cherry-pick-3.1, needs-cherry-pick-4.0, needs-cherry-pick-5.0, needs-cherry-pick-master, question, require-LGT1, require-LGT2, require-LGT3, special-week, v4.0, v5.0, v6.0, version-specific-changes-required, website.

Details

In response to this:

/label for-future-release

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

…privs

TomShawn · 2021-05-07T09:09:55Z

/cc @tiancaiamao @bb7133
/translation doing
/assign @Joyinqin

tiancaiamao · 2021-05-19T04:44:58Z

/LGTM

…privs

TomShawn · 2021-05-31T09:44:01Z

/hold

qiancai · 2021-05-31T09:47:40Z

Hi @morgo, we are preparing the user docs for TiDB v5.1 and would like to know whether the doc changes of this PR apply to TiDB v5.1 or not. Would you please check and reply? Thanks!

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

morgo · 2021-06-01T19:19:09Z

I have added the privilege RESTORE_ADMIN to the document. It has not merged yet, but should shortly: pingcap/tidb#25039

This is the result of a discussion to a bug fix where we determined this was the best outcome.

TomShawn · 2021-06-02T02:12:27Z

/lgtm

ti-chi-bot · 2021-06-02T02:12:28Z

@TomShawn: Please use GitHub review feature instead of /lgtm [cancel] when you want to submit review to the pull request.
For how to use GitHub review feature, see also this document provided by GitHub.

For the reason we drop support to the commands, see also this page.
This reply is being used as a temporary reply during the migration of review process and will be removed on July 1st.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2021-06-02T02:15:55Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

TomShawn
tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

TomShawn · 2021-06-03T02:47:24Z

@Joyinqin This PR is ready for translation. Thanks!

Joyinqin · 2021-06-04T06:49:17Z

/translation done
/remove-translation doing

TomShawn · 2021-06-08T11:03:33Z

/merge

ti-chi-bot · 2021-06-08T11:03:35Z

This pull request has been accepted and is ready to merge.

Details

Commit hash: 221930d

Add docs for dynamic privileges

f6b4dbb

ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 22, 2021

morgo mentioned this pull request Mar 22, 2021

*: add support for dynamic privileges pingcap/tidb#22778

Merged

pingcap deleted a comment from ti-chi-bot Mar 24, 2021

yikeke added for-future-release This PR only applies to master for now and might cherry-pick to a future release. requires-followup This PR requires a follow-up task after being merged. labels Mar 24, 2021

morgo added 3 commits April 1, 2021 20:53

Update privilege-management.md

87f34ec

fix broken link

acb2b01

Merge remote-tracking branch 'upstream/master' into document-dynamic-…

396aef5

…privs

ti-chi-bot assigned Joyinqin May 7, 2021

ti-chi-bot added the translation/doing This PR's assignee is translating this PR. label May 7, 2021

ti-chi-bot requested review from bb7133 and tiancaiamao May 7, 2021 09:09

ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label May 7, 2021

bb7133 reviewed May 7, 2021

View reviewed changes

Comment thread privilege-management.md Outdated

Update wording

0c5ba3c

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 19, 2021

Merge remote-tracking branch 'upstream/master' into document-dynamic-…

0cc0824

…privs

morgo mentioned this pull request May 27, 2021

*: Change dynamic privileges to non-experimental pingcap/tidb#24914

Merged

TomShawn requested a review from bb7133 May 27, 2021 09:27

ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 31, 2021

Remove experimental

47e654a

qiancai added v5.1 This PR/issue applies to TiDB v5.1. and removed for-future-release This PR only applies to master for now and might cherry-pick to a future release. labels May 31, 2021

TomShawn added sig/docs Indicates that the Issue or PR belongs to the docs SIG. area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. labels Jun 1, 2021

TomShawn reviewed Jun 1, 2021

View reviewed changes

Comment thread privilege-management.md Outdated

Comment thread privilege-management.md Outdated

morgo and others added 2 commits May 31, 2021 21:53

Update privilege-management.md

1279938

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

Add wording for since 5.1.

f4459b6

TomShawn reviewed Jun 1, 2021

View reviewed changes

Comment thread privilege-management.md Outdated

morgo and others added 2 commits June 1, 2021 13:17

Update privilege-management.md

47077b4

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

Add restore admin privilege

8f10eff

TomShawn approved these changes Jun 2, 2021

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 2, 2021

Add dynamic privileges starting version.

221930d

ti-chi-bot added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Jun 4, 2021

Joyinqin mentioned this pull request Jun 4, 2021

Add docs for dynamic privileges pingcap/docs-cn#6407

Merged

12 tasks

TomShawn removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 8, 2021

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 8, 2021

ti-chi-bot merged commit 2f61c30 into pingcap:master Jun 8, 2021

morgo deleted the document-dynamic-privs branch June 9, 2021 01:02

TomShawn removed the requires-followup This PR requires a follow-up task after being merged. label Jul 2, 2021

Conversation

morgo commented Mar 22, 2021

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

Uh oh!

yikeke commented Mar 24, 2021

Uh oh!

ti-chi-bot commented Mar 24, 2021

Uh oh!

ti-chi-bot commented Mar 24, 2021

Uh oh!

TomShawn commented May 7, 2021

Uh oh!

Uh oh!

tiancaiamao commented May 19, 2021

Uh oh!

TomShawn commented May 31, 2021

Uh oh!

qiancai commented May 31, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

morgo commented Jun 1, 2021

Uh oh!

TomShawn commented Jun 2, 2021

Uh oh!

ti-chi-bot commented Jun 2, 2021

Uh oh!

ti-chi-bot commented Jun 2, 2021

Uh oh!

TomShawn commented Jun 3, 2021

Uh oh!

Joyinqin commented Jun 4, 2021

Uh oh!

TomShawn commented Jun 8, 2021

Uh oh!

ti-chi-bot commented Jun 8, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants