Skip to content

*: add support for dynamic privileges#22778

Merged
ti-chi-bot merged 19 commits into
pingcap:masterfrom
morgo:initial-support-dynamic-privs
Mar 31, 2021
Merged

*: add support for dynamic privileges#22778
ti-chi-bot merged 19 commits into
pingcap:masterfrom
morgo:initial-support-dynamic-privs

Conversation

@morgo
Copy link
Copy Markdown
Contributor

@morgo morgo commented Feb 16, 2021 •
edited
Loading

What problem does this PR solve?

This adds dynamic privileges support (a feature from MySQL 8.0). The initial list of dynamic privileges is a static list, but it is possible to extend in future so that plugins can add their own privileges.

Problem Summary:

What is changed and how it works?

Proposal: #23224

What's Changed:

How it Works:

Related changes

Check List

Tests

  • Unit test

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM

Release note

  • Initial support for Dynamic Privileges (a MySQL 8.0 feature) has been added.

@morgo
Copy link
Copy Markdown
Contributor Author

morgo commented Feb 16, 2021

/run-all-tests

@github-actions github-actions Bot added sig/execution SIG execution sig/sql-infra SIG: SQL Infra labels Feb 16, 2021
@morgo
Copy link
Copy Markdown
Contributor Author

morgo commented Feb 16, 2021

The common-test failures are caused by the error messages changed. Some permissions no longer require SUPER but SUPER or x.

@bb7133
Copy link
Copy Markdown
Member

bb7133 commented Feb 18, 2021

/bench

bb7133
bb7133 reviewed Feb 18, 2021
View reviewed changes
Comment thread executor/grant.go
bb7133
bb7133 reviewed Feb 18, 2021
View reviewed changes
Comment thread executor/grant_test.go
bb7133
bb7133 reviewed Feb 19, 2021
View reviewed changes
Comment thread privilege/privileges/privileges_test.go Outdated
@morgo morgo marked this pull request as ready for review February 20, 2021 02:44
@morgo morgo requested review from a team as code owners February 20, 2021 02:44
@morgo morgo requested review from eurekaka and qw4990 and removed request for a team February 20, 2021 02:44
@bb7133
Copy link
Copy Markdown
Member

bb7133 commented Feb 23, 2021

LGTM

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Feb 23, 2021

@bb7133: Please use /LGTM instead of LGTM when you want to approve the pull request by comment.
If you use the GitHub review feature, please approve the PR directly, the comment will not take effect in the GitHub review feature.
If you have any qustions please refer to lgtm command help or lgtm plugin design.

If you have approved this PR, please ignore this reply. This reply is being used as a temporary reply during the migration of the new bot and will be removed on April 1.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 23, 2021
@bb7133
Copy link
Copy Markdown
Member

bb7133 commented Feb 23, 2021

But we don't merge it into master for now since it is not in current release plan.

@bb7133
Copy link
Copy Markdown
Member

bb7133 commented Feb 23, 2021

PTAL @tiancaiamao

@0xPoe
Copy link
Copy Markdown
Member

0xPoe commented Feb 23, 2021

But we don't merge it into master for now since it is not in current release plan.

Try this:

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 23, 2021
@bb7133
Copy link
Copy Markdown
Member

bb7133 commented Feb 25, 2021

/lgtm

@bb7133
Copy link
Copy Markdown
Member

bb7133 commented Feb 25, 2021

/hold

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Mar 29, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 2018a34

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 29, 2021
@tiancaiamao
Copy link
Copy Markdown
Contributor

tiancaiamao commented Mar 29, 2021

CI fails. mysql-test needs to be updated @morgo

@0xPoe
Copy link
Copy Markdown
Member

0xPoe commented Mar 29, 2021

/run-all-tests

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Mar 29, 2021
@morgo
Copy link
Copy Markdown
Contributor Author

morgo commented Mar 29, 2021

/run-all-tests tidb-test=pr/1176

@morgo
Copy link
Copy Markdown
Contributor Author

morgo commented Mar 30, 2021

@tiancaiamao PTAL again. Note that some new code was introduced in 763325a

@tiancaiamao
Copy link
Copy Markdown
Contributor

tiancaiamao commented Mar 30, 2021

/LGTM

@tiancaiamao tiancaiamao requested a review from bb7133 March 30, 2021 12:08
@bb7133
Copy link
Copy Markdown
Member

bb7133 commented Mar 31, 2021

/lgtm

@bb7133
Copy link
Copy Markdown
Member

bb7133 commented Mar 31, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Mar 31, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 66f23a1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 31, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Mar 31, 2021

@morgo: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lysu
Copy link
Copy Markdown
Contributor

lysu commented Mar 31, 2021

/merge

@lysu lysu mentioned this pull request Mar 31, 2021
Merged
@ti-chi-bot ti-chi-bot merged commit 90d02b2 into pingcap:master Mar 31, 2021
@morgo morgo deleted the initial-support-dynamic-privs branch March 31, 2021 16:17
@morgo morgo mentioned this pull request Apr 1, 2021
Merged
@morgo morgo mentioned this pull request Apr 19, 2021
Closed
@Joyinqin Joyinqin mentioned this pull request Jun 4, 2021
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiancaiamao tiancaiamao tiancaiamao left review comments

@eurekaka eurekaka Awaiting requested review from eurekaka

@bb7133 bb7133 Awaiting requested review from bb7133

Assignees

No one assigned

Labels

sig/execution SIG execution sig/sql-infra SIG: SQL Infra size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@morgo @bb7133 @ti-chi-bot @0xPoe @tiancaiamao @lysu