Skip to content

add V4.0 tidb binlog restriction#5128

Merged
ti-chi-bot merged 9 commits into
pingcap:release-4.0from
Joyinqin:restriction-4.0
Mar 29, 2021
Merged

add V4.0 tidb binlog restriction#5128
ti-chi-bot merged 9 commits into
pingcap:release-4.0from
Joyinqin:restriction-4.0

Conversation

@Joyinqin
Copy link
Copy Markdown
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

add V4.0 tidb binlog restriction

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 26, 2021
@Joyinqin
Copy link
Copy Markdown
Contributor Author

/translation from-docs-cn

@ti-chi-bot ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. and removed missing-translation-status This PR does not have translation status info. labels Mar 26, 2021
@Joyinqin
Copy link
Copy Markdown
Contributor Author

/cc @IANTHEREAL @yikeke

@ti-chi-bot ti-chi-bot requested review from IANTHEREAL and yikeke March 26, 2021 06:51
@Joyinqin
Copy link
Copy Markdown
Contributor Author

/uncc IANTHEREAL

@ti-chi-bot ti-chi-bot removed the request for review from IANTHEREAL March 26, 2021 07:11
@Joyinqin
Copy link
Copy Markdown
Contributor Author

/cc @ran-huang

@ti-chi-bot ti-chi-bot requested a review from ran-huang March 26, 2021 08:27
Comment thread tidb-binlog/tidb-binlog-overview.md Outdated
* You need to use TiDB v2.0.8-binlog, v2.1.0-rc.5 or a later version. Older versions of TiDB cluster are not compatible with the cluster version of TiDB Binlog.
* TiDB Binlog is incompatible with the following feature introduced in TiDB v4.0.7 and they cannot be used together:

- TiDB system variable [tidb_enable_amend_pessimistic_txn](/system-variables.md#tidb_enable_amend_pessimistic_txn-new-in-v407): The two features have compatibility issues. Using them together will cause correctness issues with inconsistent replication data of TiDB Binlog.
Copy link
Copy Markdown
Contributor

@ran-huang ran-huang Mar 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- TiDB system variable [tidb_enable_amend_pessimistic_txn](/system-variables.md#tidb_enable_amend_pessimistic_txn-new-in-v407): The two features have compatibility issues. Using them together will cause correctness issues with inconsistent replication data of TiDB Binlog.
- TiDB system variable [tidb_enable_amend_pessimistic_txn](/system-variables.md#tidb_enable_amend_pessimistic_txn-new-in-v407): The two features have compatibility issues. Using them together might cause the issue that TiDB Binlog replicates data inconsistently.

Co-authored-by: Ran <huangran@pingcap.com>
@ran-huang
Copy link
Copy Markdown
Contributor

/lgtm

@ti-chi-bot
Copy link
Copy Markdown
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 26, 2021
@yikeke
Copy link
Copy Markdown
Contributor

yikeke commented Mar 29, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 475849f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 29, 2021
@ti-chi-bot ti-chi-bot merged commit c615c39 into pingcap:release-4.0 Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants