add binlog usage restrictions by IANTHEREAL · Pull Request #5832 · pingcap/docs-cn

IANTHEREAL · 2021-03-25T03:00:25Z

First-time contributors' checklist

I've signed Contributor License Agreement that's required for repo owners to accept my contribution.

What is changed, added or deleted? (Required)

Increase the restriction of using binlog in version 5.0

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Other reference link(s):
- Async Commit: https://github.com/pingcap/docs-cn/pull/5607/files
- Clustered Index: https://github.com/pingcap/docs-cn/pull/5771/files

Do your changes match any of the following descriptions?

Delete files
Change aliases
Need modification after applied to another branch
Might cause conflicts after applied to another branch

Co-authored-by: leoppro <i@leop.pro>

IANTHEREAL · 2021-03-25T03:22:03Z

@sticnarf PTAL

zier-one

/lgtm

sticnarf

LGTM

ti-chi-bot · 2021-03-25T03:25:57Z

@sticnarf: /lgtm is only allowed for the reviewers in list.

Details

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

yikeke · 2021-03-25T06:55:29Z

+* TiDB Binlog 与 TiDB v4.0.7 版本开始引入的以下特性不兼容，无法一起使用：
+
+    - TiDB 系统变量 [tidb_enable_amend_pessimistic_txn](/system-variables.md#tidb_enable_amend_pessimistic_txn-从-v407-版本开始引入)：两个功能存在兼容性问题，一起使用会造成 TiDB Binlog 复制数据不一致的正确性问题。


这个提醒得 cherry-pick 到 4.0 文档吧？

可以，这个合并后，我把这段挪过去

Co-authored-by: Coco Yee <40977455+yikeke@users.noreply.github.com>

ti-chi-bot · 2021-03-25T08:45:50Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

yikeke

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

yikeke · 2021-03-25T08:46:10Z

/merge

ti-chi-bot · 2021-03-25T08:46:12Z

@yikeke: /merge in this pull request requires 2 /lgtm.

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

yikeke · 2021-03-25T08:46:56Z

/status LGT2

yikeke · 2021-03-25T08:47:08Z

/merge

ti-chi-bot · 2021-03-25T08:47:10Z

This pull request has been accepted and is ready to merge.

Details

Commit hash: cd3dddd

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot · 2021-03-25T08:47:57Z

cherry pick to release-5.0 in PR #5840

Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Co-authored-by: Ian <ArGregoryIan@gmail.com>

Joyinqin · 2021-03-26T06:53:54Z

/translation done

Joyinqin · 2021-03-26T06:54:02Z

/remove-translation doing

add binlog usage restrictions

a14941c

ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 25, 2021

IANTHEREAL added 2 commits March 25, 2021 11:08

Update tidb-binlog-overview.md

4396f9d

Update tidb-binlog-overview.md

02170dd

zier-one reviewed Mar 25, 2021

View reviewed changes

Comment thread tidb-binlog/tidb-binlog-overview.md Outdated

Comment thread tidb-binlog/tidb-binlog-overview.md Outdated

IANTHEREAL and others added 2 commits March 25, 2021 11:16

Update tidb-binlog/tidb-binlog-overview.md

495bb6b

Co-authored-by: leoppro <i@leop.pro>

Update tidb-binlog/tidb-binlog-overview.md

d98080c

Co-authored-by: leoppro <i@leop.pro>

zier-one reviewed Mar 25, 2021

View reviewed changes

sticnarf approved these changes Mar 25, 2021

View reviewed changes

yikeke added needs-cherry-pick-5.0 translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Mar 25, 2021

yikeke assigned Joyinqin Mar 25, 2021

yikeke added the v5.0 This PR/issue applies to TiDB v5.0 label Mar 25, 2021

yikeke reviewed Mar 25, 2021

View reviewed changes

Update tidb-binlog/tidb-binlog-overview.md

cd3dddd

Co-authored-by: Coco Yee <40977455+yikeke@users.noreply.github.com>

yikeke approved these changes Mar 25, 2021

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 25, 2021

ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Mar 25, 2021

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 25, 2021

ti-chi-bot merged commit 31bd8f6 into pingcap:master Mar 25, 2021

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Mar 25, 2021

cherry pick pingcap#5832 to release-5.0

79b38d1

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot mentioned this pull request Mar 25, 2021

add binlog usage restrictions (#5832) #5840

Merged

11 tasks

yikeke added the requires-followup This PR requires a follow-up task after being merged. label Mar 25, 2021

yikeke pushed a commit that referenced this pull request Mar 25, 2021

cherry pick #5832 to release-5.0 (#5840)

fd80a72

Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Co-authored-by: Ian <ArGregoryIan@gmail.com>

IANTHEREAL deleted the binlog-limit branch March 25, 2021 12:36

Joyinqin mentioned this pull request Mar 26, 2021

add binlog usage restrictions pingcap/docs#5125

Merged

11 tasks

yikeke removed the requires-followup This PR requires a follow-up task after being merged. label Mar 26, 2021

yikeke mentioned this pull request Mar 26, 2021

add V4.0 tidb binlog restriction #5853

Merged

9 tasks

Joyinqin mentioned this pull request Mar 26, 2021

add V4.0 tidb binlog restriction pingcap/docs#5128

Merged

11 tasks

ti-chi-bot added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Mar 26, 2021

ti-chi-bot removed the translation/doing This PR’s assignee is translating this PR. label Mar 26, 2021

ti-srebot mentioned this pull request Mar 29, 2021

add binlog usage restrictions (#5125) pingcap/docs#5158

Merged

11 tasks

		* TiDB Binlog 与 TiDB v4.0.7 版本开始引入的以下特性不兼容，无法一起使用：

		- TiDB 系统变量 [tidb_enable_amend_pessimistic_txn](/system-variables.md#tidb_enable_amend_pessimistic_txn-从-v407-版本开始引入)：两个功能存在兼容性问题，一起使用会造成 TiDB Binlog 复制数据不一致的正确性问题。

Conversation

IANTHEREAL commented Mar 25, 2021

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

Uh oh!

Uh oh!

Uh oh!

IANTHEREAL commented Mar 25, 2021

Uh oh!

zier-one left a comment

Choose a reason for hiding this comment

Uh oh!

sticnarf left a comment

Choose a reason for hiding this comment

Uh oh!

ti-chi-bot commented Mar 25, 2021

Uh oh!

Uh oh!

yikeke Mar 25, 2021

Choose a reason for hiding this comment

Uh oh!

IANTHEREAL Mar 25, 2021

Choose a reason for hiding this comment

Uh oh!

ti-chi-bot commented Mar 25, 2021

Uh oh!

yikeke commented Mar 25, 2021

Uh oh!

ti-chi-bot commented Mar 25, 2021

Uh oh!

yikeke commented Mar 25, 2021

Uh oh!

yikeke commented Mar 25, 2021

Uh oh!

ti-chi-bot commented Mar 25, 2021

Uh oh!

ti-srebot commented Mar 25, 2021

Uh oh!

Joyinqin commented Mar 26, 2021

Uh oh!

Joyinqin commented Mar 26, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants