add binlog usage restrictions by Joyinqin · Pull Request #5125 · pingcap/docs

Joyinqin · 2021-03-26T03:44:29Z

First-time contributors' checklist

I've signed Contributor License Agreement that's required for repo owners to accept my contribution.

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

This PR is translated from: add binlog usage restrictions docs-cn#5832
Other reference link(s):

Do your changes match any of the following descriptions?

Delete files
Change aliases
Need modification after applied to another branch
Might cause conflicts after applied to another branch

Joyinqin · 2021-03-26T03:44:58Z

/translation from-docs-cn
/label v5.0
/label needs-cherry-pick-5.0

Joyinqin · 2021-03-26T09:06:43Z

/cc @ran-huang @sticnarf

Joyinqin · 2021-03-26T09:15:06Z

/uncc sticnarf

Joyinqin · 2021-03-26T09:15:16Z

/cc @IANTHEREAL

ran-huang · 2021-03-26T09:17:24Z


+> **Note:**
+>
+> TiDB Binlog is not compatible with some features introduced in TiDB v5.0.0-rc and they cannot be used together. For details, see [Notes](#notes). It is recommended to use [TiCDC](/ticdc/ticdc-overview.md) instead.


Suggested change

> TiDB Binlog is not compatible with some features introduced in TiDB v5.0.0-rc and they cannot be used together. For details, see [Notes](#notes). It is recommended to use [TiCDC](/ticdc/ticdc-overview.md) instead.

> TiDB Binlog is not compatible with some features introduced in TiDB v5.0.0-rc, and they cannot be used together. For details, see [Notes](#notes). It is recommended to use [TiCDC](/ticdc/ticdc-overview.md) instead of TiDB Binlog.

Let's make it clear that we are talking about "Binlog" rather than "features introduced in 5.0 rc"

ran-huang · 2021-03-26T09:22:32Z

tidb-binlog/tidb-binlog-overview.md
   59:7-59:64  warning  Dead anchor: /clustered-indexes.md#limitations                                                                           pingcap-docs-anchors  remark-lint
  61:28-61:98  warning  Dead anchor: /system-variables.md#tidb_enable_1pc-new-in-v500-rc. Did you mean #tidb_enable_async_commit-new-in-v500-rc  pingcap-docs-anchors  remark-lint

Please fix 2 dead anchors.

IANTHEREAL · 2021-03-26T09:30:31Z

-* Drainer supports replicating binlogs to MySQL, TiDB, Kafka or local files. If you need to replicate binlogs to other Drainer unsuppored destinations, you can set Drainer to replicate the binlog to Kafka and read the data in Kafka for customized processing according to binlog consumer protocol. See [Binlog Consumer Client User Guide](/tidb-binlog/binlog-consumer-client.md).
-
-* To use TiDB Binlog for recovering incremental data, set the config `db-type` to `file` (local files in the proto buffer format). Drainer converts the binlog to data in the specified [proto buffer format](https://github.com/pingcap/tidb-binlog/blob/master/proto/binlog.proto) and writes the data to local files. In this way, you can use [Reparo](/tidb-binlog/tidb-binlog-reparo.md) to recover data incrementally.
+* TiDB Binlog is not compatible with the following features introduced in TiDB v5.0.0-rc and they cannot be used together:


can we put you can use [TiCDC](/ticdc/ticdc-overview.md) instead. after this sentence, and remove the same content in its clause

IANTHEREAL · 2021-03-26T09:31:14Z

Rest LGTM

Joyinqin · 2021-03-26T10:31:48Z

tidb-binlog/tidb-binlog-overview.md
   59:7-59:64  warning  Dead anchor: /clustered-indexes.md#limitations                                                                           pingcap-docs-anchors  remark-lint
  61:28-61:98  warning  Dead anchor: /system-variables.md#tidb_enable_1pc-new-in-v500-rc. Did you mean #tidb_enable_async_commit-new-in-v500-rc  pingcap-docs-anchors  remark-lint

Please fix 2 dead anchors.

Waiting for #5129 to merge. Another one has been fixed.

Joyinqin · 2021-03-26T10:41:02Z

@ran-huang PTAL again,thx~

ran-huang · 2021-03-26T10:55:08Z

/lgtm

ti-chi-bot · 2021-03-26T10:55:10Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

IANTHEREAL · 2021-03-29T03:11:00Z

/lgtm

ti-chi-bot · 2021-03-29T03:11:03Z

@IANTHEREAL: /lgtm is only allowed for the reviewers in list.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ran-huang · 2021-03-29T03:15:12Z

/label require-LGT1

CharLotteiu · 2021-03-29T11:26:26Z

/rebase

yikeke · 2021-03-29T11:34:11Z

/rebase

yikeke · 2021-03-29T11:42:15Z

/merge

ti-chi-bot · 2021-03-29T11:42:17Z

This pull request has been accepted and is ready to merge.

Details

Commit hash: adcc283

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot · 2021-03-29T11:45:57Z

cherry pick to release-5.0 in PR #5158

ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 26, 2021

ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v5.0 This PR/issue applies to TiDB v5.0. needs-cherry-pick-5.0 and removed missing-translation-status This PR does not have translation status info. labels Mar 26, 2021

Joyinqin marked this pull request as ready for review March 26, 2021 08:50

ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 26, 2021

ti-chi-bot requested review from ran-huang and sticnarf March 26, 2021 09:06

ti-chi-bot removed the request for review from sticnarf March 26, 2021 09:15

ti-chi-bot requested a review from IANTHEREAL March 26, 2021 09:15

ran-huang reviewed Mar 26, 2021

View reviewed changes

IANTHEREAL reviewed Mar 26, 2021

View reviewed changes

Comment thread tidb-binlog/tidb-binlog-overview.md

IANTHEREAL reviewed Mar 26, 2021

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 26, 2021

ti-chi-bot added the require-LGT1 Indicates that the PR requires an LGTM. label Mar 29, 2021

Joyinqin added 8 commits March 29, 2021 11:38

Update tidb-binlog-overview.md

b6ec5b1

Update tidb-binlog-overview.md

86db98d

Update tidb-binlog-overview.md

710693a

Update tidb-binlog-overview.md

d0d3e88

Update tidb-binlog-overview.md

b1a6a51

Update tidb-binlog-overview.md

67a76ec

Update tidb-binlog-overview.md

620e0c9

Update tidb-binlog-overview.md

adcc283

github-actions Bot force-pushed the binlog-limit branch from 0df86c5 to adcc283 Compare March 29, 2021 11:38

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 29, 2021

ti-chi-bot merged commit 51769e2 into pingcap:master Mar 29, 2021

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Mar 29, 2021

cherry pick pingcap#5125 to release-5.0

20643e0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot mentioned this pull request Mar 29, 2021

add binlog usage restrictions (#5125) #5158

Merged

11 tasks

ti-chi-bot pushed a commit that referenced this pull request Mar 29, 2021

add binlog usage restrictions (#5125) (#5158)

ec522de

	> TiDB Binlog is not compatible with some features introduced in TiDB v5.0.0-rc and they cannot be used together. For details, see [Notes](#notes). It is recommended to use [TiCDC](/ticdc/ticdc-overview.md) instead.
	> TiDB Binlog is not compatible with some features introduced in TiDB v5.0.0-rc, and they cannot be used together. For details, see [Notes](#notes). It is recommended to use [TiCDC](/ticdc/ticdc-overview.md) instead of TiDB Binlog.

Conversation

Joyinqin commented Mar 26, 2021

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

Uh oh!

Joyinqin commented Mar 26, 2021

Uh oh!

Joyinqin commented Mar 26, 2021

Uh oh!

Joyinqin commented Mar 26, 2021

Uh oh!

Joyinqin commented Mar 26, 2021

Uh oh!

ran-huang Mar 26, 2021

Choose a reason for hiding this comment

Uh oh!

ran-huang commented Mar 26, 2021

Uh oh!

Uh oh!

IANTHEREAL Mar 26, 2021

Choose a reason for hiding this comment

Uh oh!

IANTHEREAL commented Mar 26, 2021

Uh oh!

Joyinqin commented Mar 26, 2021

Uh oh!

Joyinqin commented Mar 26, 2021

Uh oh!

ran-huang commented Mar 26, 2021

Uh oh!

ti-chi-bot commented Mar 26, 2021

Uh oh!

IANTHEREAL commented Mar 29, 2021

Uh oh!

ti-chi-bot commented Mar 29, 2021

Uh oh!

ran-huang commented Mar 29, 2021

Uh oh!

CharLotteiu commented Mar 29, 2021

Uh oh!

yikeke commented Mar 29, 2021

Uh oh!

yikeke commented Mar 29, 2021

Uh oh!

ti-chi-bot commented Mar 29, 2021

Uh oh!

ti-srebot commented Mar 29, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants